search

99designs / thumbor_botornado

Thumbor S3 backend based on botornado async client.
MIT License
21 stars 7 forks source link

Fix import #8

Closed phoet closed 9 years ago

phoet commented 9 years ago

using s3_http_loader.rb in thumbor results in an error:

Traceback (most recent call last):
  File "thumbor_botornado/s3_http_loader.py", line 2, in <module>
    import tornado.concurrent.return_future
ImportError: No module named return_future

so i changed the import to be the same as in s3_loader.py

pda commented 9 years ago

Huh, thanks. I wonder how it was working in our environment.

phoet commented 9 years ago

computers, how do they work?! ¯(ツ)/¯

pda commented 9 years ago

Ohhh… it looks like I fixed this error, amended my commit, tagged it v2.0.1 and pushed the tag, but never pushed it to master.

I've now force-pushed the v2.0.1 commit to master (after this merge, therefore overwriting it) so that the v2.0.1 doesn't forever point at an orphan (widow? leaf?) commit. And like any git push --force I'll probably regret it at some point.

Thanks for pointing out the problem. Turns out the computers are working fine, but I'm not ;)