search

99x / 99x.github.io

Listing all public GitHub projects in a given organization
MIT License
14 stars 31 forks source link

Not clickable repos in mobile view fix #115

Open shalithasuranga opened 7 years ago

shalithasuranga commented 7 years ago

This closes #109

Explanation Issue was the height was 0px due to inner floated elements. I just added display : table

dinukadesilva commented 7 years ago

@shalithasuranga This issue causes due to the missing bootstrap classes. And adding them fixes this. And no need of changing display to table which is kind of not recommended in bootstrap.

If you could add the following missing classes to all the places where it's missing, this would be solved.

col-lg-12 col-md-12 col-sm-12 col-xs-12

shalithasuranga commented 7 years ago

@dinukadesilva Thanks for the idea. if we usecol-lg-12 will stretch to the screen. How about using clearfix class. I already pushed to this PR.

Thanks

dinukadesilva commented 7 years ago

That way it works I guess. But, I would prefer having defined all four classes. BTW there are few other places this has to be updated in index.js.

shalithasuranga commented 7 years ago

Hi @dinukadesilva clearfix solves the issue. Btw To where you are suggesting to add col-lg-12 col-md-12 col-sm-12 col-xs-12 classes ?

dinukadesilva commented 7 years ago

I'll let you decide whether it's clearfix or adding all four grid CSS classes. There few places in index.js missing some grid CSS classes that you have to update though it's working.

eg:- https://github.com/99xt/99xt.github.io/blob/7ab550a0e761dc8ad9666024fff878293ac507d5/js/index.js#L149

chamathpali commented 6 years ago

Whats the status on this @dinukadesilva @shalithasuranga ?