search

99x / contributors-shield

Generate an image for the contributors of a repo
2 stars 13 forks source link

Added s3 bucket integration #31

Open shalithasuranga opened 7 years ago

shalithasuranga commented 7 years ago

This closes #12

Added following option set for s3 bucket configuration 

// Remote upload Settings
var uploadToS3Bucket = true;
var bucketOptions = {
    bucketName: '99xtest2',
    key: '' // optional eg :- filename.png
};

If we set uploadToS3Bucket = true output will be changed as per below and image will be added to the specific s3 bucket

image

please review @chamathpali @rehrumesh Can I update README too?

Thanks

chamathpali commented 7 years ago

@shalithasuranga is this based on the AWS account associated with the Lambda? or how is the S3 Credentials/Access is set ?

shalithasuranga commented 7 years ago

@chamathpali I stored API credentials in C:\Users\USERNAME\.aws\credentials file using this format 

[default]
aws_access_key_id = your_access_key
aws_secret_access_key = your_secret_key
chamathpali commented 7 years ago

but this will be a serverless integration #9 . so it will be in a lambda function. and not on a dedicated server

shalithasuranga commented 7 years ago

@chamathpali Okay. Then Can I store credentials setup inside the code?