Fix for windows users using this library via 'serverless-dynamodb-local'

99x / dynamodb-localhost

Dynamodb localhost runner for development and testing

MIT License

35 stars 92 forks source link

Fix for windows users using this library via 'serverless-dynamodb-local' #47

Open martineca opened 5 years ago

martineca commented 5 years ago

Adding 'shell:true' to the starter.js file. This will fix issues that are affecting windows user when they are trying to start local dynamodb via the serverless-dynamodb-local package. The process starts and immediately shuts down.

AshanFernando commented 5 years ago

Thanks @martineca for the PR. I'm also tagging @mjzone to test this in a Mac to see whether it has an effect there as well. Will merge once I get the verification.

martineca commented 5 years ago

It turns out that this change would cause issues on linux. I will investigate further.

AshanFernando commented 5 years ago

@martineca Let us know if you come across a fix for Linux. @mjzone tested on Mac and it seems to work fine there.

martineca commented 5 years ago

@AshanFernando by using detached:true instead of shell:true the fix should work on all platforms now.