Closed shapkarin closed 5 years ago
Can you try looking at the latest changes? I've made a few in the master branch.
Cool, seem that I removed my comment about that 🙂
About 'count props', what's your suggestion here
Cli asking about number of props. I don't like that.. So count them somehow. I didn't thought how but like just define them for a start with cli input prop1 prop2 prop3 then asking for an each type or even with types already prop:type.
I plan to rename Parent and Child and remove postfix ".react.js" by default but with possibility to add any by config file. Are you OK with that?
I think we don't need any prefixes according to current practices we don't use prefixes in react component files.
Cli asking about number of props. I don't like that.. So count them somehow. I didn't thought how but like just define them for a start with cli input prop1 prop2 prop3 then asking for an each type or even with types already prop:type.
How do we stop adding the props, if we don't know how many there are?
Perhaps ask the user after adding each prop to proceed to the next step?
No. I mean we can ask to input all props before you define types, then count words in string separated by space and then to ask type for each. For example to make array like:
const props = "prop1 prop2 prop3".split(" ")
const count = props.length
Great, can you send a PR for this?
Sure I will.
@rajikaimal I add some todos to the list.
@rajikaimal OK, I'll create other issues for other changes.
And as CONTRIBUTING.md says "Clarify the issue or the feature that's going to be implemented"
Also maybe I'll add some features for redux.
I do not agree with name like parent or child, but I like format that you use to store templates and interactive cli.