99x / react-scaffolder

:zap: Scaffolding tool for React
MIT License
44 stars 14 forks source link

Fixes: #53 #54

Closed shapkarin closed 5 years ago

shapkarin commented 5 years ago

First steps for issues #53

Changes: count props, add default config, remove filename postfix

rajikaimal commented 5 years ago

I will test soon and merge this. Thanks! 🎉

shapkarin commented 5 years ago

I run that like:

node ./bin/initialize.js generate component Test That

But if run tests, "should create a parent react component" is failed.

shapkarin commented 5 years ago

fixed "generate" test 🙂

shapkarin commented 5 years ago

I don't like that I save empty folder (somebody can think that source there...), but can't generate to the different directories. I also plan to do that at issues #53

shapkarin commented 5 years ago

I renamed to "test_folder" but still think that all about tests must be in one folder but I found some other at "templates/src"

shapkarin commented 5 years ago

@rajikaimal what is the "templates/src" folder? I change test and .reactclirc to generate there and then remove generated folder.

rajikaimal commented 5 years ago

templates folder contains the default react template.

shapkarin commented 5 years ago

templates folder contains the default react template.

@rajikaimal but what for src/components inside?

shapkarin commented 5 years ago

I changed test so it's generate to the "./test_folder/components" folder and then removes it.

rajikaimal commented 5 years ago

but what for src/components inside?

We don't have an src folder.

Other changes LGTM.

rajikaimal commented 5 years ago

Let's create issues for the other features/patches.

Thanks! 🙇 @shapkarin