search

9dogs / tg-odesli-bot

Telegram Bot to share music with Odesli (former Songlink) service.
https://t.me/odesli_bot
GNU General Public License v3.0
78 stars 21 forks source link

Apple music link incorrect format #39

Closed vdmklchv closed 1 year ago

vdmklchv commented 1 year ago

Please fix Apple music link format. Sample from odesli bot is this - https://geo.music.apple.com/us/album/_/1549781001?mt=1&app=music&ls=1&at=1000lHKX&ct=api_http&itscg=30200&itsct=odsl_m

image

it adds geo prefix to URL, while the installed app on the phone does not recognize it and it is opened in browser.

If we remove geo and use URL - https://music.apple.com/us/album/_/1549781001?mt=1&app=music&ls=1&at=1000lHKX&ct=api_http&itscg=30200&itsct=odsl_m it opens correctly in the app.

9dogs commented 1 year ago

I believe we take these links from the Odesli service without any changes, but I'll look into it. So simply removing geo. is enough?

vdmklchv commented 1 year ago

Yes, we can confirm that on Android devices Apple music app can correctly be open without geo. prefix. We, however, are unable to see if it changes something on Apple devices, but I believe it should work ok there both ways, with and without geo and only Android app has problems opening it.

AlexWayfer commented 1 year ago

I'd like to see this in production. There are still links with geo.

9dogs commented 1 year ago

My bad. I dropped Python 3.7 support and the package hadn't been updated automatically on the server. Could you check again? Should be working now.

AlexWayfer commented 1 year ago

I see no geo now. Thank you.