search

9elements / converged-security-suite

Converged Security Suite for Intel & AMD platform security features
https://www.9esec.io
BSD 3-Clause "New" or "Revised" License
59 stars 15 forks source link

WIP: Get the CI in beast mode. #227

Closed ChriMarMe closed 3 years ago

ChriMarMe commented 3 years ago

Signed-off-by: Christopher Meis christopher.meis@9elements.com

ChriMarMe commented 3 years ago

Goal: Having tests for every PKG and getting them to pass.

ChriMarMe commented 3 years ago 
pkg/diff/analyze.go:8:2: a blank import should be only in a main or test package, or have a comment justifying it
pkg/diff/diff.go:5:2: a blank import should be only in a main or test package, or have a comment justifying it
pkg/diff/diff.go:10:1: exported function Diff should have comment or be unexported
Found 3 lint suggestions; failing.
pkg/errors/multi_error_test.go:12:68: error strings should not be capitalized or end with punctuation or a newline
Found 1 lint suggestions; failing.
cannot find package "./pkg/intel/fit" in:
        pkg/intel/fit
cannot find package "./pkg/intel/fit/consts" in:
        pkg/intel/fit/consts
pkg/pcd/errors.go:108:6: exported type ErrUnknownVendorType should have comment or be unexported
pkg/pcd/parse_firmware.go:41:6: exported type ParsedFirmwareGeneric should have comment or be unexported
pkg/pcd/parse_firmware.go:49:1: exported method ParsedFirmwareGeneric.GetFirmwareVendorVersion should have comment or be unexported
pkg/pcd/parse_firmware.go:53:1: exported method ParsedFirmwareGeneric.GetFirmwareVendorVersionRanges should have comment or be unexported
pkg/pcd/parse_firmware.go:57:1: exported method ParsedFirmwareGeneric.GetFirmwareVendorVersionCodeRanges should have comment or be unexported
pkg/pcd/parse_firmware.go:61:1: exported method ParsedFirmwareGeneric.GetFirmwareVendorVersionFFSGUID should have comment or be unexported
pkg/pcd/parse_firmware.go:65:6: exported type FirmwareImage should have comment or be unexported
pkg/pcd/parse_firmware_ocp.go:47:6: exported type ParsedFirmwareOCPGeneric should have comment or be unexported
pkg/pcd/parse_firmware_ocp.go:51:1: exported method ParsedFirmwareOCPGeneric.GetFirmwareVendorVersion should have comment or be unexported
Found 9 lint suggestions; failing.
pkg/pcr/flow.go:27:1: exported function FlowFromString should have comment or be unexported
pkg/pcr/flow_detection.go:14:1: exported function DetectTPM should have comment or be unexported
pkg/pcr/flow_detection.go:107:1: exported function DetectAttestationFlow should have comment or be unexported
pkg/pcr/get_measurements.go:9:6: exported type Firmware should have comment or be unexported
pkg/pcr/get_measurements_pcr0_cbnt0t.go:45:1: exported function MeasurePCR0Data should have comment or be unexported
pkg/pcr/get_measurements_pcr0_legacytxtdisabled.go:14:1: exported function MeasurePCDFirmwareVendorVersionData should have comment or be unexported
pkg/pcr/get_measurements_pcr0_legacytxtdisabled.go:32:1: exported function MeasurePCDFirmwareVendorVersionCode should have comment or be unexported
pkg/pcr/get_measurements_pcr0_legacytxtdisabled.go:48:1: exported function MeasureDXE should have comment or be unexported
pkg/pcr/get_measurements_pcr0_legacytxtdisabled.go:81:1: exported function MeasureFITPointer should have comment or be unexported
pkg/pcr/get_measurements_pcr0_legacytxtdisabled.go:90:1: exported function MeasureFITHeaders should have comment or be unexported
pkg/pcr/get_measurements_pcr0_legacytxtdisabled.go:103:1: exported function MeasureSeparator should have comment or be unexported
pkg/pcr/get_measurements_pcr0_legacytxtenabled.go:14:1: exported function MeasureInit should have comment or be unexported
pkg/pcr/get_measurements_pcr0_legacytxtenabled.go:18:1: exported function MeasureACMDate should have comment or be unexported
pkg/pcr/get_measurements_pcr0_legacytxtenabled.go:47:1: exported function MeasureACMDateInPlace should have comment or be unexported
pkg/pcr/get_measurements_pcr0_legacytxtenabled.go:87:1: exported function MeasureBIOSStartupModule should have comment or be unexported
pkg/pcr/get_measurements_pcr0_legacytxtenabled.go:111:1: exported function MeasureSCRTMSeparator should have comment or be unexported
pkg/pcr/measure_option.go:17:1: comment on exported type SetFlow should be of the form "SetFlow ..." (with optional leading article)
pkg/pcr/measure_option.go:49:6: exported type SetRegisters should have comment or be unexported
pkg/pcr/measure_option.go:51:1: exported method SetRegisters.Apply should have comment or be unexported
pkg/pcr/measure_option.go:56:6: exported type SetTPMDevice should have comment or be unexported
pkg/pcr/measure_option.go:58:1: exported method SetTPMDevice.Apply should have comment or be unexported
pkg/pcr/measurement.go:61:1: exported method DataChunk.CompileMeasurableData should have comment or be unexported
pkg/pcr/measurement.go:68:6: exported type DataChunks should have comment or be unexported
pkg/pcr/measurement.go:95:1: exported function NewStaticDataChunk should have comment or be unexported
pkg/pcr/measurement.go:102:1: exported function NewRangeDataChunk should have comment or be unexported
pkg/pcr/measurement.go:192:1: exported function NewStaticDataMeasurement should have comment or be unexported
pkg/pcr/measurement.go:203:1: exported function NewRangesMeasurement should have comment or be unexported
pkg/pcr/measurement.go:214:1: exported function NewRangeMeasurement should have comment or be unexported
pkg/pcr/measurement.go:313:6: exported type Printfer should have comment or be unexported
pkg/pcr/measurement_id.go:34:2: exported const MeasurementIDUndefined should have comment (or a comment on this block) or be unexported
pkg/pcr/measurement_id.go:36:2: don't use underscores in Go names; const MeasurementIDPCR0_DATA should be MeasurementIDPCR0DATA
pkg/pcr/measurement_id.go:115:1: exported method MeasurementID.PCRIDs should have comment or be unexported
pkg/pcr/measurement_id.go:306:2: exported const DataChunkIDUndefined should have comment (or a comment on this block) or be unexported
Found 33 lint suggestions; failing.
pkg/registers/msr.go:11:6: exported type MSRReader should have comment or be unexported
pkg/registers/msr.go:15:6: exported type DefaultMSRReader should have comment or be unexported
pkg/registers/msr_boot_guard_pbec.go:3:7: exported const BootGuardPBECRegisterID should have comment or be unexported
pkg/registers/msr_boot_guard_pbec.go:4:7: exported const BootGuardPBECRegisterOffset should have comment or be unexported
pkg/registers/msr_boot_guard_pbec.go:6:6: exported type BootGuardPBEC should have comment or be unexported
pkg/registers/msr_boot_guard_pbec.go:8:1: exported method BootGuardPBEC.ID should have comment or be unexported
pkg/registers/msr_boot_guard_pbec.go:12:1: exported method BootGuardPBEC.BitSize should have comment or be unexported
pkg/registers/msr_boot_guard_pbec.go:16:1: exported method BootGuardPBEC.Address should have comment or be unexported
pkg/registers/msr_boot_guard_pbec.go:20:1: exported method BootGuardPBEC.Fields should have comment or be unexported
pkg/registers/msr_boot_guard_pbec.go:34:1: exported method BootGuardPBEC.Raw should have comment or be unexported
pkg/registers/msr_boot_guard_pbec.go:38:1: exported method BootGuardPBEC.StopPBET should have comment or be unexported
pkg/registers/msr_btg_sacm_info.go:3:7: exported const BTGSACMInfoRegisterID should have comment or be unexported
pkg/registers/msr_btg_sacm_info.go:4:7: exported const BTGSACMInfoRegisterOffset should have comment or be unexported
pkg/registers/msr_btg_sacm_info.go:6:6: exported type BTGSACMInfo should have comment or be unexported
pkg/registers/msr_btg_sacm_info.go:8:1: exported method BTGSACMInfo.ID should have comment or be unexported
pkg/registers/msr_btg_sacm_info.go:12:1: exported method BTGSACMInfo.BitSize should have comment or be unexported
pkg/registers/msr_btg_sacm_info.go:16:1: exported method BTGSACMInfo.Address should have comment or be unexported
pkg/registers/msr_btg_sacm_info.go:20:1: exported method BTGSACMInfo.Fields should have comment or be unexported
pkg/registers/msr_btg_sacm_info.go:78:1: exported method BTGSACMInfo.Raw should have comment or be unexported
pkg/registers/msr_btg_sacm_info.go:82:1: exported method BTGSACMInfo.NEMEnabled should have comment or be unexported
pkg/registers/msr_btg_sacm_info.go:86:1: exported method BTGSACMInfo.TPMType should have comment or be unexported
pkg/registers/msr_btg_sacm_info.go:90:1: exported method BTGSACMInfo.TPMSuccess should have comment or be unexported
pkg/registers/msr_btg_sacm_info.go:94:1: exported method BTGSACMInfo.ForceAnchorBoot should have comment or be unexported
pkg/registers/msr_btg_sacm_info.go:98:1: exported method BTGSACMInfo.Measured should have comment or be unexported
pkg/registers/msr_btg_sacm_info.go:102:1: exported method BTGSACMInfo.Verified should have comment or be unexported
pkg/registers/msr_btg_sacm_info.go:106:1: exported method BTGSACMInfo.ModuleRevoked should have comment or be unexported
pkg/registers/msr_btg_sacm_info.go:110:1: exported method BTGSACMInfo.BootGuardCapability should have comment or be unexported
pkg/registers/msr_btg_sacm_info.go:114:1: exported method BTGSACMInfo.ServerTXTCapability should have comment or be unexported
pkg/registers/msr_btg_sacm_info.go:118:1: exported method BTGSACMInfo.NoResetSecretsProtection should have comment or be unexported
pkg/registers/msr_ia32_debug_interface.go:3:7: exported const IA32DebugInterfaceRegisterID should have comment or be unexported
pkg/registers/msr_ia32_debug_interface.go:4:7: exported const IA32DebugInterfaceRegisterOffset should have comment or be unexported
pkg/registers/msr_ia32_debug_interface.go:6:6: exported type IA32DebugInterface should have comment or be unexported
pkg/registers/msr_ia32_debug_interface.go:8:1: exported method IA32DebugInterface.ID should have comment or be unexported
pkg/registers/msr_ia32_debug_interface.go:12:1: exported method IA32DebugInterface.BitSize should have comment or be unexported
pkg/registers/msr_ia32_debug_interface.go:16:1: exported method IA32DebugInterface.Address should have comment or be unexported
pkg/registers/msr_ia32_debug_interface.go:20:1: exported method IA32DebugInterface.Fields should have comment or be unexported
pkg/registers/msr_ia32_debug_interface.go:46:1: exported method IA32DebugInterface.Raw should have comment or be unexported
pkg/registers/msr_ia32_debug_interface.go:50:1: exported method IA32DebugInterface.Enabled should have comment or be unexported
pkg/registers/msr_ia32_debug_interface.go:54:1: exported method IA32DebugInterface.Locked should have comment or be unexported
pkg/registers/msr_ia32_debug_interface.go:58:1: exported method IA32DebugInterface.DebugOccurred should have comment or be unexported
pkg/registers/msr_ia32_feature_control.go:3:7: exported const IA32FeatureControlRegisterID should have comment or be unexported
pkg/registers/msr_ia32_feature_control.go:4:7: exported const IA32FeatureControlRegisterOffset should have comment or be unexported
pkg/registers/msr_ia32_feature_control.go:6:6: exported type IA32FeatureControl should have comment or be unexported
pkg/registers/msr_ia32_feature_control.go:8:1: exported method IA32FeatureControl.ID should have comment or be unexported
pkg/registers/msr_ia32_feature_control.go:12:1: exported method IA32FeatureControl.BitSize should have comment or be unexported
pkg/registers/msr_ia32_feature_control.go:16:1: exported method IA32FeatureControl.Address should have comment or be unexported
pkg/registers/msr_ia32_feature_control.go:20:1: exported method IA32FeatureControl.Fields should have comment or be unexported
pkg/registers/msr_ia32_feature_control.go:54:1: exported method IA32FeatureControl.Raw should have comment or be unexported
pkg/registers/msr_ia32_feature_control.go:58:1: exported method IA32FeatureControl.Locked should have comment or be unexported
pkg/registers/msr_ia32_feature_control.go:62:1: exported method IA32FeatureControl.VMXInSMXEnabled should have comment or be unexported
pkg/registers/msr_ia32_feature_control.go:66:1: exported method IA32FeatureControl.VMXOutsideSMXEnabled should have comment or be unexported
pkg/registers/msr_ia32_feature_control.go:70:1: exported method IA32FeatureControl.SENTEREnables should have comment or be unexported
pkg/registers/msr_ia32_feature_control.go:74:1: exported method IA32FeatureControl.SENTERGlobalEnable should have comment or be unexported
pkg/registers/msr_ia32_mtrrcap.go:3:7: exported const IA32MTRRCAPRegisterID should have comment or be unexported
pkg/registers/msr_ia32_mtrrcap.go:4:7: exported const IA32MTRRCAPRegisterOffset should have comment or be unexported
pkg/registers/msr_ia32_mtrrcap.go:6:6: exported type IA32MTRRCAP should have comment or be unexported
pkg/registers/msr_ia32_mtrrcap.go:8:1: exported method IA32MTRRCAP.ID should have comment or be unexported
pkg/registers/msr_ia32_mtrrcap.go:12:1: exported method IA32MTRRCAP.BitSize should have comment or be unexported
pkg/registers/msr_ia32_mtrrcap.go:16:1: exported method IA32MTRRCAP.Address should have comment or be unexported
pkg/registers/msr_ia32_mtrrcap.go:20:1: exported method IA32MTRRCAP.Fields should have comment or be unexported
pkg/registers/msr_ia32_mtrrcap.go:50:1: exported method IA32MTRRCAP.VariableRangeRegistersCount should have comment or be unexported
pkg/registers/msr_ia32_mtrrcap.go:54:1: exported method IA32MTRRCAP.FixedRangedRegisteredSupported should have comment or be unexported
pkg/registers/msr_ia32_mtrrcap.go:58:1: exported method IA32MTRRCAP.WriteCombiningMemoryTypeSupported should have comment or be unexported
pkg/registers/msr_ia32_mtrrcap.go:62:1: exported method IA32MTRRCAP.SMRRInterfaceSupported should have comment or be unexported
pkg/registers/msr_ia32_mtrrcap.go:66:1: exported method IA32MTRRCAP.Raw should have comment or be unexported
pkg/registers/msr_ia32_platform_id.go:3:7: exported const IA32PlatformIDRegisterID should have comment or be unexported
pkg/registers/msr_ia32_platform_id.go:4:7: exported const IA32PlatformIDRegisterOffset should have comment or be unexported
pkg/registers/msr_ia32_platform_id.go:6:6: exported type IA32PlatformID should have comment or be unexported
pkg/registers/msr_ia32_platform_id.go:8:1: exported method IA32PlatformID.ID should have comment or be unexported
pkg/registers/msr_ia32_platform_id.go:12:1: exported method IA32PlatformID.BitSize should have comment or be unexported
pkg/registers/msr_ia32_platform_id.go:16:1: exported method IA32PlatformID.Address should have comment or be unexported
pkg/registers/msr_ia32_platform_id.go:20:1: exported method IA32PlatformID.Fields should have comment or be unexported
pkg/registers/msr_ia32_platform_id.go:38:1: exported method IA32PlatformID.Raw should have comment or be unexported
pkg/registers/msr_ia32_platform_id.go:42:1: exported method IA32PlatformID.ProcessorFlag should have comment or be unexported
pkg/registers/msr_ia32_smrr_physbase.go:3:7: exported const IA32SMRRPhysBaseRegisterID should have comment or be unexported
pkg/registers/msr_ia32_smrr_physbase.go:4:7: exported const IA32SMRRPhysBaseRegisterOffset should have comment or be unexported
pkg/registers/msr_ia32_smrr_physbase.go:6:6: exported type IA32SMRRPhysBase should have comment or be unexported
pkg/registers/msr_ia32_smrr_physbase.go:8:1: exported method IA32SMRRPhysBase.ID should have comment or be unexported
pkg/registers/msr_ia32_smrr_physbase.go:12:1: exported method IA32SMRRPhysBase.BitSize should have comment or be unexported
pkg/registers/msr_ia32_smrr_physbase.go:16:1: exported method IA32SMRRPhysBase.Address should have comment or be unexported
pkg/registers/msr_ia32_smrr_physbase.go:20:1: exported method IA32SMRRPhysBase.Fields should have comment or be unexported
pkg/registers/msr_ia32_smrr_physbase.go:42:1: exported method IA32SMRRPhysBase.Raw should have comment or be unexported
pkg/registers/msr_ia32_smrr_physbase.go:46:1: exported method IA32SMRRPhysBase.Type should have comment or be unexported
pkg/registers/msr_ia32_smrr_physbase.go:50:1: exported method IA32SMRRPhysBase.PhysBase should have comment or be unexported
pkg/registers/msr_ia32_smrr_physmask.go:3:7: exported const IA32SMRRPhysMaskRegisterID should have comment or be unexported
pkg/registers/msr_ia32_smrr_physmask.go:4:7: exported const IA32SMRRPhysMaskRegisterOffset should have comment or be unexported
pkg/registers/msr_ia32_smrr_physmask.go:6:6: exported type IA32SMRRPhysMask should have comment or be unexported
pkg/registers/msr_ia32_smrr_physmask.go:8:1: exported method IA32SMRRPhysMask.ID should have comment or be unexported
pkg/registers/msr_ia32_smrr_physmask.go:12:1: exported method IA32SMRRPhysMask.BitSize should have comment or be unexported
pkg/registers/msr_ia32_smrr_physmask.go:16:1: exported method IA32SMRRPhysMask.Address should have comment or be unexported
pkg/registers/msr_ia32_smrr_physmask.go:20:1: exported method IA32SMRRPhysMask.Fields should have comment or be unexported
pkg/registers/msr_ia32_smrr_physmask.go:42:1: exported method IA32SMRRPhysMask.Raw should have comment or be unexported
pkg/registers/msr_ia32_smrr_physmask.go:46:1: exported method IA32SMRRPhysMask.Valid should have comment or be unexported
pkg/registers/msr_ia32_smrr_physmask.go:50:1: exported method IA32SMRRPhysMask.PhysMask should have comment or be unexported
pkg/registers/msr_ia32_smrr_physmask.go:70:1: comment on exported function FindIA32SMRRPhysMask should be of the form "FindIA32SMRRPhysMask ..."
pkg/registers/tpm_type.go:3:6: exported type TPMType should have comment or be unexported
pkg/registers/tpm_type.go:6:2: exported const TPMTypeNoTpm should have comment (or a comment on this block) or be unexported
pkg/registers/txt_acm_policy_status.go:9:7: exported const AcmPolicyStatusRegisterID should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:10:7: exported const ACMPolicyStatusRegisterOffset should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:12:6: exported type BackupAction should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:15:2: exported const BackupActionMemoryPowerDown should have comment (or a comment on this block) or be unexported
pkg/registers/txt_acm_policy_status.go:21:6: exported type MemoryScrubbingPolicy should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:24:2: exported const MemoryScrubbingPolicyDefault should have comment (or a comment on this block) or be unexported
pkg/registers/txt_acm_policy_status.go:30:6: exported type SCRTMStatus should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:33:2: exported const SCRTMStatusNone should have comment (or a comment on this block) or be unexported
pkg/registers/txt_acm_policy_status.go:39:6: exported type TPMStartupLocality should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:42:2: exported const TPMStartupLocality0 should have comment (or a comment on this block) or be unexported
pkg/registers/txt_acm_policy_status.go:46:6: exported type ACMPolicyStatus should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:48:1: exported method ACMPolicyStatus.ID should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:52:1: exported method ACMPolicyStatus.Raw should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:56:1: exported method ACMPolicyStatus.BitSize should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:60:1: exported method ACMPolicyStatus.Address should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:64:1: exported method ACMPolicyStatus.Fields should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:163:1: exported method ACMPolicyStatus.KMID should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:168:1: exported method ACMPolicyStatus.BootPolicyM should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:173:1: exported method ACMPolicyStatus.BootPolicyV should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:178:1: exported method ACMPolicyStatus.BootPolicyHAP should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:183:1: exported method ACMPolicyStatus.BootPolicyT should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:188:1: exported method ACMPolicyStatus.BootPolicyDCD should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:193:1: exported method ACMPolicyStatus.BootPolicyDBI should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:198:1: exported method ACMPolicyStatus.BootPolicyPBE should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:203:1: exported method ACMPolicyStatus.TPMType should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:208:1: exported method ACMPolicyStatus.TPMSuccess should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:213:1: exported method ACMPolicyStatus.BootPolicyP should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:218:1: exported method ACMPolicyStatus.BackupAction should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:223:1: exported method ACMPolicyStatus.TXTProfileSelection should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:228:1: exported method ACMPolicyStatus.MemoryScrubbingPolicy should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:233:1: exported method ACMPolicyStatus.IBBDmaProtection should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:238:1: exported method ACMPolicyStatus.SCRTMStatus should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:243:1: exported method ACMPolicyStatus.CPUCoSigningEnabled should have comment or be unexported
pkg/registers/txt_acm_policy_status.go:248:1: exported method ACMPolicyStatus.TPMStartupLocality should have comment or be unexported
pkg/registers/txt_acm_status.go:8:7: exported const ACMStatusRegisterID should have comment or be unexported
pkg/registers/txt_acm_status.go:9:7: exported const ACMStatusRegisterOffset should have comment or be unexported
pkg/registers/txt_acm_status.go:14:1: exported method ACMStatus.ID should have comment or be unexported
pkg/registers/txt_acm_status.go:18:1: exported method ACMStatus.BitSize should have comment or be unexported
pkg/registers/txt_acm_status.go:22:1: exported method ACMStatus.Address should have comment or be unexported
pkg/registers/txt_acm_status.go:26:1: exported method ACMStatus.Fields should have comment or be unexported
pkg/registers/txt_acm_status.go:60:1: exported method ACMStatus.Raw should have comment or be unexported
pkg/registers/txt_acm_status.go:68:1: exported method ACMStatus.ModuleType should have comment or be unexported
pkg/registers/txt_acm_status.go:72:1: exported method ACMStatus.ClassCode should have comment or be unexported
pkg/registers/txt_acm_status.go:76:1: exported method ACMStatus.MajorErrorCode should have comment or be unexported
pkg/registers/txt_acm_status.go:80:1: exported method ACMStatus.ACMStarted should have comment or be unexported
pkg/registers/txt_acm_status.go:84:1: exported method ACMStatus.MinorErrorCode should have comment or be unexported
pkg/registers/txt_acm_status.go:88:1: exported method ACMStatus.Valid should have comment or be unexported
pkg/registers/txt_bootstatus.go:8:7: exported const TXTBootStatusRegisterID should have comment or be unexported
pkg/registers/txt_bootstatus.go:9:7: exported const TXTBootStatusRegisterOffset should have comment or be unexported
pkg/registers/txt_bootstatus.go:11:6: exported type TXTBootStatus should have comment or be unexported
pkg/registers/txt_bootstatus.go:13:1: exported method TXTBootStatus.ID should have comment or be unexported
pkg/registers/txt_bootstatus.go:17:1: exported method TXTBootStatus.Raw should have comment or be unexported
pkg/registers/txt_bootstatus.go:21:1: exported method TXTBootStatus.BitSize should have comment or be unexported
pkg/registers/txt_bootstatus.go:25:1: exported method TXTBootStatus.Address should have comment or be unexported
pkg/registers/txt_bootstatus.go:29:1: exported method TXTBootStatus.Fields should have comment or be unexported
pkg/registers/txt_bootstatus.go:83:1: exported method TXTBootStatus.TXTStartupSuccess should have comment or be unexported
pkg/registers/txt_bootstatus.go:87:1: exported method TXTBootStatus.BootStatus should have comment or be unexported
pkg/registers/txt_bootstatus.go:91:1: exported method TXTBootStatus.MemoryPowerDownExecuted should have comment or be unexported
pkg/registers/txt_bootstatus.go:95:1: exported method TXTBootStatus.BootStatusDetails should have comment or be unexported
pkg/registers/txt_bootstatus.go:99:1: exported method TXTBootStatus.TXTPolicyEnable should have comment or be unexported
pkg/registers/txt_bootstatus.go:103:1: exported method TXTBootStatus.BootStatusDetails2 should have comment or be unexported
pkg/registers/txt_bootstatus.go:107:1: exported method TXTBootStatus.BIOSTrusted should have comment or be unexported
pkg/registers/txt_bootstatus.go:111:1: exported method TXTBootStatus.TXTPolicyDisable should have comment or be unexported
pkg/registers/txt_bootstatus.go:115:1: exported method TXTBootStatus.BootStatusDetails3 should have comment or be unexported
pkg/registers/txt_bootstatus.go:119:1: exported method TXTBootStatus.ACMAuthenticationError should have comment or be unexported
pkg/registers/txt_bootstatus.go:123:1: exported method TXTBootStatus.SACMASuccess should have comment or be unexported
pkg/registers/txt_device_id.go:8:7: exported const TXTDeviceIDRegisterID should have comment or be unexported
pkg/registers/txt_device_id.go:9:7: exported const TXTDeviceIDRegisterOffset should have comment or be unexported
pkg/registers/txt_device_id.go:11:6: exported type TXTDeviceID should have comment or be unexported
pkg/registers/txt_device_id.go:13:1: exported method TXTDeviceID.ID should have comment or be unexported
pkg/registers/txt_device_id.go:17:1: exported method TXTDeviceID.Raw should have comment or be unexported
pkg/registers/txt_device_id.go:21:1: exported method TXTDeviceID.BitSize should have comment or be unexported
pkg/registers/txt_device_id.go:25:1: exported method TXTDeviceID.Address should have comment or be unexported
pkg/registers/txt_device_id.go:29:1: exported method TXTDeviceID.Fields should have comment or be unexported
pkg/registers/txt_device_id.go:51:1: exported method TXTDeviceID.VendorID should have comment or be unexported
pkg/registers/txt_device_id.go:55:1: exported method TXTDeviceID.DeviceID should have comment or be unexported
pkg/registers/txt_device_id.go:59:1: exported method TXTDeviceID.RevisionID should have comment or be unexported
pkg/registers/txt_device_id.go:63:1: exported method TXTDeviceID.ExtendedID should have comment or be unexported
pkg/registers/txt_dpr.go:8:7: exported const TXTDMAProtectedRangeRegisterID should have comment or be unexported
pkg/registers/txt_dpr.go:9:7: exported const TXTDMAProtectedRangeRegisterOffset should have comment or be unexported
pkg/registers/txt_dpr.go:20:6: exported type TXTDMAProtectedRange should have comment or be unexported
pkg/registers/txt_dpr.go:22:1: exported method TXTDMAProtectedRange.ID should have comment or be unexported
pkg/registers/txt_dpr.go:26:1: exported method TXTDMAProtectedRange.Raw should have comment or be unexported
pkg/registers/txt_dpr.go:30:1: exported method TXTDMAProtectedRange.BitSize should have comment or be unexported
pkg/registers/txt_dpr.go:34:1: exported method TXTDMAProtectedRange.Address should have comment or be unexported
pkg/registers/txt_dpr.go:38:1: exported method TXTDMAProtectedRange.Fields should have comment or be unexported
pkg/registers/txt_dpr.go:64:1: exported method TXTDMAProtectedRange.DMAProtectedRange should have comment or be unexported
pkg/registers/txt_error_code.go:8:7: exported const TXTErrorCodeRegisterID should have comment or be unexported
pkg/registers/txt_error_code.go:9:7: exported const TXTErrorCodeRegisterOffset should have comment or be unexported
pkg/registers/txt_error_code.go:11:6: exported type TXTErrorReporter should have comment or be unexported
pkg/registers/txt_error_code.go:14:2: exported const ProcessorTXTErrorReporter should have comment (or a comment on this block) or be unexported
pkg/registers/txt_error_code.go:21:1: exported method TXTErrorCode.ID should have comment or be unexported
pkg/registers/txt_error_code.go:25:1: exported method TXTErrorCode.Raw should have comment or be unexported
pkg/registers/txt_error_code.go:29:1: exported method TXTErrorCode.BitSize should have comment or be unexported
pkg/registers/txt_error_code.go:33:1: exported method TXTErrorCode.Address should have comment or be unexported
pkg/registers/txt_error_code.go:37:1: exported method TXTErrorCode.Fields should have comment or be unexported
pkg/registers/txt_error_code.go:75:1: exported method TXTErrorCode.ModuleType should have comment or be unexported
pkg/registers/txt_error_code.go:79:1: exported method TXTErrorCode.ClassCode should have comment or be unexported
pkg/registers/txt_error_code.go:83:1: exported method TXTErrorCode.MajorErrorCode should have comment or be unexported
pkg/registers/txt_error_code.go:87:1: exported method TXTErrorCode.SoftwareSource should have comment or be unexported
pkg/registers/txt_error_code.go:91:1: exported method TXTErrorCode.MinorErrorCode should have comment or be unexported
pkg/registers/txt_error_code.go:95:1: exported method TXTErrorCode.Type1Reserved should have comment or be unexported
pkg/registers/txt_error_code.go:99:1: exported method TXTErrorCode.ProcessorOrSoftwareReporter should have comment or be unexported
pkg/registers/txt_error_code.go:106:1: exported method TXTErrorCode.Valid should have comment or be unexported
pkg/registers/txt_ests.go:8:7: exported const TXTErrorStatusRegisterID should have comment or be unexported
pkg/registers/txt_ests.go:9:7: exported const TXTErrorStatusRegisterOffset should have comment or be unexported
pkg/registers/txt_ests.go:11:6: exported type TXTErrorStatus should have comment or be unexported
pkg/registers/txt_ests.go:13:1: exported method TXTErrorStatus.ID should have comment or be unexported
pkg/registers/txt_ests.go:17:1: exported method TXTErrorStatus.Raw should have comment or be unexported
pkg/registers/txt_ests.go:21:1: exported method TXTErrorStatus.BitSize should have comment or be unexported
pkg/registers/txt_ests.go:25:1: exported method TXTErrorStatus.Address should have comment or be unexported
pkg/registers/txt_ests.go:29:1: exported method TXTErrorStatus.Fields should have comment or be unexported
pkg/registers/txt_ests.go:43:1: exported method TXTErrorStatus.Reset should have comment or be unexported
pkg/registers/txt_heap_base.go:8:7: exported const TXTHeapBaseRegisterID should have comment or be unexported
pkg/registers/txt_heap_base.go:9:7: exported const TXTHeapBaseRegisterOffset should have comment or be unexported
pkg/registers/txt_heap_base.go:11:6: exported type TXTHeapBase should have comment or be unexported
pkg/registers/txt_heap_base.go:13:1: exported method TXTHeapBase.ID should have comment or be unexported
pkg/registers/txt_heap_base.go:17:1: exported method TXTHeapBase.Raw should have comment or be unexported
pkg/registers/txt_heap_base.go:21:1: exported method TXTHeapBase.BitSize should have comment or be unexported
pkg/registers/txt_heap_base.go:25:1: exported method TXTHeapBase.Address should have comment or be unexported
pkg/registers/txt_heap_base.go:29:1: exported method TXTHeapBase.Fields should have comment or be unexported
pkg/registers/txt_heap_size.go:8:7: exported const TXTHeapSizeRegisterID should have comment or be unexported
pkg/registers/txt_heap_size.go:9:7: exported const TXTHeapSizeRegisterOffset should have comment or be unexported
pkg/registers/txt_heap_size.go:11:6: exported type TXTHeapSize should have comment or be unexported
pkg/registers/txt_heap_size.go:13:1: exported method TXTHeapSize.ID should have comment or be unexported
pkg/registers/txt_heap_size.go:17:1: exported method TXTHeapSize.Raw should have comment or be unexported
pkg/registers/txt_heap_size.go:21:1: exported method TXTHeapSize.BitSize should have comment or be unexported
pkg/registers/txt_heap_size.go:25:1: exported method TXTHeapSize.Address should have comment or be unexported
pkg/registers/txt_heap_size.go:29:1: exported method TXTHeapSize.Fields should have comment or be unexported
pkg/registers/txt_mle_join.go:8:7: exported const TXTMLEJoinRegisterID should have comment or be unexported
pkg/registers/txt_mle_join.go:9:7: exported const TXTMLEJoinRegisterOffset should have comment or be unexported
pkg/registers/txt_mle_join.go:11:6: exported type TXTMLEJoin should have comment or be unexported
pkg/registers/txt_mle_join.go:13:1: exported method TXTMLEJoin.ID should have comment or be unexported
pkg/registers/txt_mle_join.go:17:1: exported method TXTMLEJoin.Raw should have comment or be unexported
pkg/registers/txt_mle_join.go:21:1: exported method TXTMLEJoin.BitSize should have comment or be unexported
pkg/registers/txt_mle_join.go:25:1: exported method TXTMLEJoin.Address should have comment or be unexported
pkg/registers/txt_mle_join.go:29:1: exported method TXTMLEJoin.Fields should have comment or be unexported
pkg/registers/txt_public_key.go:8:7: exported const TXTPublicKeyRegisterID should have comment or be unexported
pkg/registers/txt_public_key.go:9:7: exported const TXTPublicKeyRegisterOffset should have comment or be unexported
pkg/registers/txt_public_key.go:11:6: exported type TXTPublicKey should have comment or be unexported
pkg/registers/txt_public_key.go:15:1: exported method TXTPublicKey.ID should have comment or be unexported
pkg/registers/txt_public_key.go:19:1: exported method TXTPublicKey.Raw should have comment or be unexported
pkg/registers/txt_public_key.go:23:1: exported method TXTPublicKey.BitSize should have comment or be unexported
pkg/registers/txt_public_key.go:27:1: exported method TXTPublicKey.Address should have comment or be unexported
pkg/registers/txt_public_key.go:31:1: exported method TXTPublicKey.Fields should have comment or be unexported
pkg/registers/txt_public_key.go:46:1: comment on exported function ReadTXTPublicKeyRegister should be of the form "ReadTXTPublicKeyRegister ..."
pkg/registers/txt_sinit_base.go:8:7: exported const TXTSINITBaseRegisterID should have comment or be unexported
pkg/registers/txt_sinit_base.go:9:7: exported const TXTSINITBaseRegisterOffset should have comment or be unexported
pkg/registers/txt_sinit_base.go:11:6: exported type TXTSInitBase should have comment or be unexported
pkg/registers/txt_sinit_base.go:13:1: exported method TXTSInitBase.ID should have comment or be unexported
pkg/registers/txt_sinit_base.go:17:1: exported method TXTSInitBase.Raw should have comment or be unexported
pkg/registers/txt_sinit_base.go:21:1: exported method TXTSInitBase.BitSize should have comment or be unexported
pkg/registers/txt_sinit_base.go:25:1: exported method TXTSInitBase.Address should have comment or be unexported
pkg/registers/txt_sinit_base.go:29:1: exported method TXTSInitBase.Fields should have comment or be unexported
pkg/registers/txt_sinit_base.go:58:1: comment on exported function FindTXTSInitBase should be of the form "FindTXTSInitBase ..."
pkg/registers/txt_sinit_size.go:8:7: exported const TXTSINITSizeRegisterID should have comment or be unexported
pkg/registers/txt_sinit_size.go:9:7: exported const TXTSINITSizeRegisterOffset should have comment or be unexported
pkg/registers/txt_sinit_size.go:11:6: exported type TXTSInitSize should have comment or be unexported
pkg/registers/txt_sinit_size.go:13:1: exported method TXTSInitSize.ID should have comment or be unexported
pkg/registers/txt_sinit_size.go:17:1: exported method TXTSInitSize.Raw should have comment or be unexported
pkg/registers/txt_sinit_size.go:21:1: exported method TXTSInitSize.BitSize should have comment or be unexported
pkg/registers/txt_sinit_size.go:25:1: exported method TXTSInitSize.Address should have comment or be unexported
pkg/registers/txt_sinit_size.go:29:1: exported method TXTSInitSize.Fields should have comment or be unexported
pkg/registers/txt_sinit_size.go:42:1: comment on exported function ReadTXTSInitSize should be of the form "ReadTXTSInitSize ..."
pkg/registers/txt_sinit_size.go:58:1: comment on exported function FindTXTSInitSize should be of the form "FindTXTSInitSize ..."
pkg/registers/txt_status.go:8:7: exported const TXTStatusRegisterID should have comment or be unexported
pkg/registers/txt_status.go:9:7: exported const TXTStatusRegisterOffset should have comment or be unexported
pkg/registers/txt_status.go:14:1: exported method TXTStatus.ID should have comment or be unexported
pkg/registers/txt_status.go:18:1: exported method TXTStatus.Raw should have comment or be unexported
pkg/registers/txt_status.go:22:1: exported method TXTStatus.BitSize should have comment or be unexported
pkg/registers/txt_status.go:26:1: exported method TXTStatus.Address should have comment or be unexported
pkg/registers/txt_status.go:30:1: exported method TXTStatus.Fields should have comment or be unexported
pkg/registers/txt_status.go:72:1: comment on exported method TXTStatus.SEnterDone should be of the form "SEnterDone ..."
pkg/registers/txt_status.go:77:1: comment on exported method TXTStatus.SExitDone should be of the form "SExitDone ..."
pkg/registers/txt_status.go:82:1: comment on exported method TXTStatus.MemConfigLock should be of the form "MemConfigLock ..."
pkg/registers/txt_status.go:87:1: comment on exported method TXTStatus.PrivateOpen should be of the form "PrivateOpen ..."
pkg/registers/txt_status.go:92:1: comment on exported method TXTStatus.Locality1Open should be of the form "Locality1Open ..."
pkg/registers/txt_status.go:97:1: comment on exported method TXTStatus.Locality2Open should be of the form "Locality2Open ..."
pkg/registers/txt_ver_emif.go:8:7: exported const TXTVerEMIfRegisterID should have comment or be unexported
pkg/registers/txt_ver_emif.go:9:7: exported const TXTVerEMIfRegisterOffset should have comment or be unexported
pkg/registers/txt_ver_emif.go:11:6: exported type TXTVerEMIF should have comment or be unexported
pkg/registers/txt_ver_emif.go:13:1: exported method TXTVerEMIF.ID should have comment or be unexported
pkg/registers/txt_ver_emif.go:17:1: exported method TXTVerEMIF.Raw should have comment or be unexported
pkg/registers/txt_ver_emif.go:21:1: exported method TXTVerEMIF.BitSize should have comment or be unexported
pkg/registers/txt_ver_emif.go:25:1: exported method TXTVerEMIF.Address should have comment or be unexported
pkg/registers/txt_ver_emif.go:29:1: exported method TXTVerEMIF.Fields should have comment or be unexported
pkg/registers/txt_ver_fsbif.go:8:7: exported const TXTVerFSBIfRegisterID should have comment or be unexported
pkg/registers/txt_ver_fsbif.go:9:7: exported const TXTVerFSBIfRegisterOffset should have comment or be unexported
pkg/registers/txt_ver_fsbif.go:11:6: exported type TXTVerFSBIF should have comment or be unexported
pkg/registers/txt_ver_fsbif.go:13:1: exported method TXTVerFSBIF.ID should have comment or be unexported
pkg/registers/txt_ver_fsbif.go:17:1: exported method TXTVerFSBIF.Raw should have comment or be unexported
pkg/registers/txt_ver_fsbif.go:21:1: exported method TXTVerFSBIF.BitSize should have comment or be unexported
pkg/registers/txt_ver_fsbif.go:25:1: exported method TXTVerFSBIF.Address should have comment or be unexported
pkg/registers/txt_ver_fsbif.go:29:1: exported method TXTVerFSBIF.Fields should have comment or be unexported
Found 291 lint suggestions; failing.
pkg/tpmdetection/detection.go:12:6: exported type Type should have comment or be unexported
pkg/tpmdetection/detection.go:15:2: exported const TypeNoTPM should have comment (or a comment on this block) or be unexported
Found 2 lint suggestions; failing.
pkg/tpmeventlog/event_type.go:9:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:9:2: exported const EV_PREBOOT_CERT should have comment (or a comment on this block) or be unexported
pkg/tpmeventlog/event_type.go:10:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:11:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:12:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:13:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:14:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:15:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:16:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:17:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:18:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:19:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:20:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:21:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:22:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:23:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:24:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:25:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:26:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:27:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:28:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:29:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:30:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:31:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:32:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:33:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:34:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:35:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:36:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:37:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:38:2: don't use ALL_CAPS in Go names; use CamelCase
pkg/tpmeventlog/event_type.go:39:2: don't use ALL_CAPS in Go names; use CamelCase
ChriMarMe commented 3 years ago

@xaionaro @rihter007

xaionaro commented 3 years ago

Damn, totally forgot about this.