9elements / converged-security-suite

Converged Security Suite for Intel & AMD platform security features
https://www.9esec.io
BSD 3-Clause "New" or "Revised" License
58 stars 15 forks source link

MeasureFunc returns a slice of measurements to support repeating measurements. #293

Closed rihter007 closed 3 years ago

rihter007 commented 3 years ago

Interface change, the functionality should not be affected Tested internally that behaviour of the measurements didn't change

xaionaro commented 3 years ago

@rihter007 : I'm getting hard time to understand why :(

What is "repeating measurements"?

rihter007 commented 3 years ago

@rihter007 : I'm getting hard time to understand why :(

What is "repeating measurements"?

Sorry for confusing. I was solving a task of measuring all of specific items in firmware. You can have a look on PR 295 for an example.

In general, firmware has undefined (could be 0 or 10) number of specific items. I want to measure all of them sequentially.

rihter007 commented 3 years ago

Decided to choose a better approach

xaionaro commented 3 years ago

Decided to choose a better approach

Well, basically the approach is the same. Just with attempt to leave a hint that Measurements should be single :)