search

9elements / converged-security-suite

Converged Security Suite for Intel & AMD platform security features
https://www.9esec.io
BSD 3-Clause "New" or "Revised" License
56 stars 15 forks source link

Change MeasurementIDDXE to EV_EFI_PLATFORM_FIRMWARE_BLOB2 #308

Closed trynity closed 2 years ago

trynity commented 2 years ago

On AMD Platforms, this particular measurement can be EV_EFI_PLATFORM_FIRMWARE_BLOB2 with the newer TCG 1.5 spec.

Ideally, we should be able to tell which version of the TCG spec is being used for the firmware, but this can be done right now in order to unblock.

trynity commented 2 years ago

Going to add the ability to have multiple event types for the same measurement per @rihter007's feedback

xaionaro commented 2 years ago

@rihter007, @trynity : Just a thought: May be we should use different MeasurementID for this case?

rihter007 commented 2 years ago

@rihter007, @trynity : Just a thought: May be we should use different MeasurementID for this case?

I remembered we had a discussion about it back in August. The reason behind supporting both of them is that both values fit the docs as @trynity mentioned. So, as we desire to support generic behaviour, we should make this measurementID be aligned with both options

trynity commented 2 years ago

@xaionaro @rihter007 Adjusted the approach now to allow multiple event types for a measurement, let me know if it should be further refined, I'm not quite sure how to do it in a more intelligent way (Such as detect the TCG spec version somehow)

trynity commented 2 years ago

Will address the nits in a follow-up PR