search

9elements / converged-security-suite

Converged Security Suite for Intel & AMD platform security features
https://www.9esec.io
BSD 3-Clause "New" or "Revised" License
56 stars 15 forks source link

An attempt to fix testdata/firmware/go.mod #329

Closed xaionaro closed 2 years ago

xaionaro commented 2 years ago

The initial problem was introduced by me. I was trying to use go:embed in some tests without globally changing go version from 1.13 to 1.17. So I created a dedicated go.mod file for testdata/firmware (which uses go:embed). And to make things transparent, I did replace:

replace github.com/9elements/converged-security-suite/v2/testdata/firmware => ./testdata/firmware

and

replace github.com/9elements/converged-security-suite/v2/ => ../../

But it appears testdata/firmware currently works only inside the repository. While when I try to reach github.com/9elements/converged-security-suite/v2/testdata/firmware externally I get:

$ go get github.com/9elements/converged-security-suite/v2/testdata/firmware@v0.0.0-00010101000000-000000000000
go get: github.com/9elements/converged-security-suite/v2/testdata/firmware@v0.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000

And in attempts of tuning the revision and version which works both internally and externally, I came up with this solution.

ChriMarMe commented 2 years ago

This got closed due to change of default branch from master to main. Rebase on main and rename branch, open PR again is a legit move here.