search

9elements / converged-security-suite

Converged Security Suite for Intel & AMD platform security features
https://www.9esec.io
BSD 3-Clause "New" or "Revised" License
56 stars 15 forks source link

Fiano dependency is broken, breaks build on Fedora #365

Closed kerneis-anssi closed 1 year ago

kerneis-anssi commented 1 year ago

The fiano dependency in go.mod points to a commit that is not on the main branch (anymore?), which makes go build fail in some cases. The problem is hidden by the fact that go by default fetches from a proxy operated by Google, which will happily work around this issue. But Fedora disables the Google proxy by default, so building fails there.

Steps to reproduce:

$ git clone https://github.com/9elements/converged-security-suite
$ cd converged-security-suite
$ GOPROXY=direct go mod vendor
[…]
github.com/9elements/converged-security-suite/v2/pkg/uefi/ffs imports
    github.com/linuxboot/fiano/pkg/visitors: github.com/linuxboot/fiano@v1.1.4-0.20230509204726-c0f54661a4fe: invalid version: unknown revision c0f54661a4fe

Similar issue here with more details: https://github.com/golang/go/issues/36624

xaionaro commented 1 year ago

Hm, indeed, commit c0f54661a4fe is not in the fiano repo right now. Weird. Created a PR (from branch update/fiano) to fix this.

xaionaro commented 1 year ago

The PR was merged.