ghost commented 4 years ago

See commit messages (maybe I should've opened 2 PRs).

When this works, I may refactor the code into a helper package (for both plumb and acme I implemented a p9fd type and there's a little duplication; it's all boilerplate anyway).

Trying it out with acme-lsp -proxy.addr cirno:3948 -proxy.net tcp -server 'as in README' -workspaces /path/to/wksp.

Currently stuck at this error:

file manager opening acme/log: '/mnt/acme/log' file does not exist

on 9front.

(Finding it a little hard to debug as usual tools don't work (e.g. runtime/debug.PrintStack(), CPU profiling to see where it was stuck). Since there's no git I'm actually cross-compiling from the plan9port host also.)

codecov-io commented 4 years ago

Codecov Report

Merging #34 into master will decrease coverage by 0.01%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   27.54%   27.52%   -0.02%     
==========================================
  Files          34       35       +1     
  Lines        3562     3564       +2     
==========================================
  Hits          981      981              
- Misses       2476     2478       +2     
  Partials      105      105

Impacted Files	Coverage Δ
internal/lsp/acmelsp/acmelsp.go	`8.33% <0%> (ø)`	:arrow_up:
internal/lsp/acmelsp/plumb_p9p.go	`0% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c143b86...1c15a23. Read the comment docs.

fhs commented 4 years ago

acme-lsp on master should work on plan9. Let me know if there are any issues.

9fans / acme-lsp

wip: access acme and plumb file systems via Plan 9 syscalls instead of Unix sockets #34

Codecov Report