`Key` has been removed from FormattingOptions

9fans / acme-lsp

Language Server Protocol tools for the acme text editor

MIT License

193 stars 25 forks source link

`Key` has been removed from FormattingOptions #39

Closed tw4452852 closed 2 years ago

tw4452852 commented 3 years ago

Signed-off-by: Tw tw19881113@gmail.com

fhs commented 3 years ago

I'm afraid this breaks compatibility with other LSP servers.

tw4452852 commented 3 years ago

Hi @fhs ,

I did a test on gopls and rust-analyzer, they work fine. Without this, rust-analyzer failed to deserialize our formatting request. Also I checked the latest the tsprotocol.go, it has been removed a long time ago.

fhs commented 3 years ago

How come the tests are failing?

tw4452852 commented 3 years ago

Hi @fhs

I don't know the other case, TestFormattingOptions should work now. BTW, I also checked on the master branch, they also failed...