search

9fans / plan9port

Plan 9 from User Space
https://9fans.github.io/plan9port/
Other
1.64k stars 326 forks source link

all: AIX updates #392

Closed bhuntsman closed 4 years ago

bhuntsman commented 4 years ago

On AIX, in most cases defining _ALL_SOURCE is the right thing to do. But occasionally it isn't. This gets sticky because in some cases _ALL_SOURCE is the only feature test macro that causes some things to be defined that we definitely don't want, as is the case with libdiskfs, acme, etc. In other cases, such as parts of lib9, it's the only feature test macro that defines some things we need in netinet/in.h. I wasn't able to find a good solution that fits both use cases. I'm open to suggestions for alternatives.

rsc commented 4 years ago

We simply cannot put AIX-specific tests in all these programs. We need to find a way to modify u.h and only u.h.

rsc commented 4 years ago

For concreteness, what is the problem that happens with acme without this change?