9fans / plan9port

Plan 9 from User Space
https://9fans.github.io/plan9port/
Other
1.61k stars 319 forks source link

plumber: variable names with underscores are not recognized in plumbing rules #561

Closed igorburago closed 1 year ago

igorburago commented 2 years ago

The plumb(7) manual states:

Variables may be set, between rule sets, by assignment statements in the style of rc.

However, rather surprisingly, the set of characters allowed in variable names by plumber is stricter than the one accepted by rc, and is limited to alphanumerics. The lack of support for underscores, for one, is quite unexpected—especially given that they are universally supported in variable names pretty much everywhere else (rc included).

Expanding the variable name character set all the way to the rc level would perhaps be an overkill, but, I think, it would be reasonable to at least accept underscores in addition to alphanumerics.