9names / bl702-hal

Rust Embedded HAL for Boufallo BL702 microcontroller
MIT License
10 stars 4 forks source link

[WIP] adc: basic implementation derived from stm32f4xx_hal #12

Open mattthebaker opened 1 year ago

mattthebaker commented 1 year ago

Signed-off-by: Matt Baker baker.matt.j@gmail.com

Derived from stm32f4xx_hal adc, so may differ in style slightly from blxxx hals.

Functioning for discrete reads via convert() and continuous reads via FIFO and start_conversion()/try_read()

Likely needs a lot of cleanup, particularly of comments vs the stm32 parent.

I wasn't sure how to make into_analog() specific to only the adc pins, so it can be called, but should not compile due to lack of ADC traits for those pins.

I needed to make the uart support lower baud rates to talk to the serial converter I have for testing.

9names commented 1 year ago

I took the WIP in the title of this PR to assume that it's not ready to be reviewed/merged yet, is this correct? Or is that just marking that the feature will not be completed by this PR and to review with that in mind?