-
Your code is clean. You have comments, consistent indentation, and great naming conventions. However, in terms of naming conventions, I think your choice of articlez and articlle could be improved. It…
-
https://github.com/mattyfang/f1-3-c2p1-colmar-academy/blob/master/Capstone%20Colmar/capstone.html#L9
At around 600-500px, your page gets unreasonably squished, your resizing needs to be smoother us…
-
Important for errors! You have two opening `` elements. Each HTML document should only contain one `` element - be sure to delete the opening `` element on line 6.
https://github.com/lenoreostrand…
-
While there is nothing wrong with your CSS, your formatting, visually, is really off. The biggest focus for this project was media queries and it seems like you skipped one of the sizes (medium page s…
-
https://github.com/faris-d/Colmar-Academy/blob/master/index.html#L2-L257
Your site is very responsive -- when I adjust the browser width, all of the elements adjust accordingly which is what the us…
-
When using the: left, right, top, bottom
styles you can only use 1 horizontal and 1 vertical. An element cannot be both left and right at the same time, so just use one or the other.
https://gith…
-
Great incorporation of mobile resizing! Though it may seem tedious, it is an incredibly important concept since screen sizes vary tremendously today and it’s important that you website looks exactly a…
-
Good job with the colmar site. You have good indentation and comments, just add text to your alt attributes. As a next step, consider adding another page to the site with a text box for users to enter…
ghost updated
6 years ago
-
https://github.com/mitchchev/colmar/blob/43a5ef7dceda0161844b72f0b63997fb67afaaff/resources/css/style.css#L18-L29
It helps to spread out your code and makes it easier to read if you add a single li…
-
https://github.com/PascalB90/colmar-cademy/blob/b69d37bf15e0c779d4d33f5801e39bd4a8ead951/index.html#L103
While this section looks very good, it only shows 4 courses @ 100%, if I zoom out to 90% i…