-
### Describe the bug
Some contracts implements ERC20 and ERC1155 both with EIP2535 diamond protocol. In that case, we want to import the ERC20 token.
https://polygonscan.com/token/0x127e47aba094a9a8…
-
[This ](https://github.com/mudgen/diamond-1-hardhat/blob/3da037b378195b4108b977cf2014600eeddbf67d/contracts/libraries/LibDiamond.sol#L196)check IMO provides no security benefits, but causes some of my…
-
I am trying to understand this `require` statement:
```solidity
// an immutable function is a function defined directly in a diamond
require(
_facetAddress != address(this),
"LibDiamon…
-
# Lines of code
https://github.com/code-423n4/2023-10-zksync/blob/main/code/contracts/ethereum/contracts/zksync/DiamondProxy.sol#L20
https://github.com/code-423n4/2023-10-zksync/blob/main/code/contra…
-
Currently all the facets are merged into a single one `Base` facet, so that it implements all the basic requirements of smart contracts and `EIP2535`.
We need to split them into separate facets as …
-
**🧐 Motivation**
Gaps are problematic and this: https://eips.ethereum.org/EIPS/eip-2535#facets-state-variables-and-diamond-storage seems to be a great idea.
**📝 Details**
The proposed changes loo…
-
I briefly looked at the general implementation using EIP2535 Diamonds and it looks good. It is a good example of using Diamond Storage and Solidity libraries correctly in the code, in the implementati…
-
# Lines of code
https://github.com/code-423n4/2022-10-zksync/blob/4db6c596931a291b17a4e0e2929adf810a4a0eed/ethereum/contracts/zksync/DiamondProxy.sol#L24-L27
# Vulnerability details
## Impact
ThE …
-
Diamond contract is a proxy of lookup table of addresses and function selectors. Some of the functions are specified in EIP, but they can be removed. However, current implementation inherit the `Diamo…
-
**Note: this proposal contains a lot of pseudo code and some of the core aspects of the proposal are contained in the code comments - don't skip over it**
## Table of contents
- [Abstract](#abst…