-
**Submitting author:** @lmbooth (Liam Booth)
**Repository:** https://github.com/LMBooth/pybci
**Branch with paper.md** (empty if default branch): main
**Version:** v1.0.1
**Editor:** @emdupre
**Review…
-
```
julia> AlignedSpan(1238, TimeSpan(-32,2), RoundSpanDown)
ERROR: ArgumentError: `sample_time` must be >= 0 nanoseconds
```
Not sure I understand why we require times to be positive (https://g…
-
```julia
julia> table = Legolas.read(path)
┌ Warning: The `Tables.Schema` of the `Arrow.Table` read via `Legolas.read(io_or_path)` does not appear to
│ comply with the `Legolas.SchemaVersion` indic…
-
My code was breaking because StatsModels.jl has changed the default ordering of FormulaTerm. (Intercept) used to come first, now its last. I was dependent on GLM.coef() returning the regression coeffi…
-
IMO this should be documented (docstring + entry in docs), since it is mentioned in the tour, and the uses in e.g. https://github.com/beacon-biosignals/Onda.jl/pull/133/files?diff=split&w=0#diff-5b453…
-
Semi-unexpected. I would've thought that inverting on collections that contained "straddling timespans" (i.e. spans where one end is in the `parent_span `and where one end is not in `parent_span`) wou…
-
Starting to gather some EEG resources, ideas and cool other toolboxes for future reference.
Essentially, the way I see it, we could in the future thing about the usefulness of wrappers for MNE (si…
-
Consider a signal with sample rate 1 Hz.
```
Index 1 2 3 4 5
Time (s) 0 1 2 3 4
```
Now, consider the time span 1.5s to 2.5s. Using brackets to highlight this span:
…
-
I'm not sure what the expected behaviour for indexing into a `Samples` object with an start time offset is, but after skimming the tests it doesn't seem to be tested...
In this line, it seems like …
-
In e.g.
https://github.com/beacon-biosignals/Legolas.jl/blob/9b0839c085a76a0256a1f690a166f5c91b157946/test/runtests.jl#L103-L105
I think the order of columns would be more preferable as `x`, `y`, …