-
## `> 0` is less efficient than `!= 0` for uint in require condition
Ref: https://twitter.com/GalloDaSballo/status/1485430908165443590
```
contracts/AaveV3YieldSource.sol:179: require(decimals_ > 0…
-
Here's what we have today. Feel free to suggest others in the thread!
```js
const GITHUB_REPOS = [
// chains
'bitcoin/bitcoin',
'ethereum/go-ethereum',
'ethereum/solidity',
'solana-…
0xbe1 updated
7 months ago
-
## Low
### Rounding-error can be redeemed for free
If the `_redeemAmount` is > 0 but less than the value of 1 share, 0 share will be burned while the user can withdraw non-zero amount.
https://github…
-
const FlashLoan = await hre.ethers.getContractFactory("FlashLoan");
const flashLoan = await FlashLoan.deploy("0x012bAC54348C0E635dCAc9D5FB99f06F24136C9A");
Flash Loan is not deployed.
Addres…
-
# [N-01] Unused SafeMath
## Description
`using SafeMath for uint256` is not needed since 0.8.0 solidity version.
https://github.com/pooltogether/aave-v3-yield-source/blob/e63d1b0e396a5bce89f093630c2…
-
# Question
Hello guys,
I installed required dependencies in my Angular dApp as described in the README:
```
npm install --save-dev ethers reflect-metadata
npm install @aave/contract-helpers @aav…
-
# C4-001: Revert String Size Optimization
## Impact
Shortening revert strings to fit in 32 bytes will decrease deploy time gas and will decrease runtime gas when the revert condition has been met.
…
-
Typo in the lines (https://github.com/pooltogether/aave-v3-yield-source/blob/e63d1b0e396a5bce89f093630c282ca1c6627e44/contracts/AaveV3YieldSource.sol#L38, https://github.com/pooltogether/aave-v3-yield…
-
The current [macro ](https://github.com/duneanalytics/spellbook/blob/main/macros/models/_sector/lending/lending_aave_compatible_borrow.sql#L256) for Aave V3 has a single column for the user on borrows…
-
# Summary
We list 1 low-critical finding and 1 non-critical finding:
* (Low) `_requireNotAToken` should check the token address != address(0)
* (Non) Duplicate code of address check
# (Low) `_requir…