-
Be consistent with your use of backslashes and forwardslahses. Note, on some OSs one of these relative paths would be incorrect.
https://github.com/GoranBT/f1-3-c2p1-colmar-academy/blob/master/colmar…
-
I think this max-width is way too big to implement mobile styling. I would aim somewhere between 450-600px.
https://github.com/Egglestar/f1-3-c2p1-colmar-academy/blob/master/colmar/resources/css/st…
-
I highly recommend adding this line into the head section whenever you use media queries:
https://developer.mozilla.org/en-US/docs/Mozilla/Mobile/Viewport_meta_tag
https://github.com/SeanTan…
-
It's almost always a good idea to wrap an image in a div for sizing it. I would wrap these images with divs, give the images: width: 100%; so they don't leak out of their container, and then size the …
-
https://github.com/pato13/f1-3-c2p1-colmar-academy/blob/master/capstone/index.html#L87
Like your nav, it seems your sidebar has issues converting when the page gets smaller. Review your media queri…
-
https://github.com/pato13/f1-3-c2p1-colmar-academy/blob/master/capstone/index.html#L12-L40
Seems your nav bar doesn't transition to the mobile version no matter how small I make the page. Use your …
-
Users expect to see a pointer when they hover over a button. For an improved UX, de-nest the anchor from this div and then change the box model properties on the anchor itself or add the cursor: point…
-
Some of these class names are a little too generic. You really don't want to start putting numbers in your class names, try to make them descriptive. It's okay to make class names long:
.large-column…
-
Great job on your mobile nav
https://github.com/DebDebMN/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademy/index.html#L51-L60
-
Great job with your documentation. Very professional!
https://github.com/DebDebMN/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademy/index.html#L14-L24