-
Event, Outputs etc... have a reference on the service and the only reason they have this is to have a nice error message. The service is never needed in the actual business logic, it's just user cosme…
-
https://github.com/mesg-foundation/core/blob/bd84ad1d54eadfb8aa2bd79ac0c7c68f775f9c03/execution/complete.go#L20-L26
This previous code is one of many similar code in the app when the caller have to c…
-
## Proposal
The goal is to allow developer to change services without changing anything in their app (expect the service ids).
Services should have the same events and tasks definition in the `me…
-
The loader on service start is missing. It was available before refactoring.
-
https://github.com/mesg-foundation/core/blob/5b52201/service/dependency.go#L15 remove this method if there is no logic depends on sorted keys.
consider using reflect.DeepEqual to compare maps in te…
-
I saw in quite a lot of files this boring piece of code to access value of maps and return an error if not found:
https://github.com/mesg-foundation/core/blob/bd84ad1d54eadfb8aa2bd79ac0c7c68f775f9c03…
-
## Proposal
The goal is to make application as DRY as possible and reusability is something important so why not apply this also for services and compose services based on other services to use an…
-
Here is a very small issue :
**Issue**
Classic variable names containing digits after the first character are considered invalid.
**Expected**
Classic variables names should follow the standar…
-
The errors of the validation functions for the service's data are not good enough. They are not explicit enough.
https://github.com/mesg-foundation/core/blob/bd84ad1d54eadfb8aa2bd79ac0c7c68f775f9c0…
-
e.g. following doesn't work because test2 has a number.
```
name: TestLogs
dependencies:
test:
image: nginx
test2:
image: nginx`
```
should we update schema to allow numbers?…