-
https://github.com/hubiinetwork/nahmii-sdk/blob/13b6010b6a488df1d591be1cccda46b5ad87659c/lib/wallet/wallet.js#L91
This method should be documented like the other methods. Does it really belong in t…
morfj updated
5 years ago
-
-
Swallowing error such as these can potentially lead to a disaster by allowing the function to keep running without handling the error. As a **minimum** the error should be debug logged. If its actuall…
morfj updated
5 years ago
-
- [x] getAddress method
- [x] getBalance method
- [x] getTransactionCount method
- [x] sendTransaction method
- [x] sign method
- [x] signMessage method
eg tests should fail if signingKey isn…
-
It appears on ln 96 in `nahmii-provider.js`, `Promise.reject` is thrown and not caught anywhere within the SDK.
The function throwing `Promise.reject` is initiated from a call to the `NahmiiProvid…
-
Is it possible, when you send your funds into another address , to add a button that calculate remaining balance and place figure that shows max possible funds to send (given specific gas price)? Same…
-
Previously it was possible to instantiate a Payment object without a real provider or a wallet instance through the `from()` function:
```JavaScript
const payment = sdk.Payment.from(json);
return…
-
-
Refactor based on the data structure changes in https://github.com/hubiinetwork/nahmii-contracts/releases/tag/v1.0-ropsten.6
- [x] Support Null Settlement
- [x] Refactor `getCurrentPaymentChalleng…
katat updated
5 years ago
-
`nahmii config` does not hand the prompt back which means I have to Ctrl + z after it.