-
The documented way is:
```
svc, err := service.WithModules(
rpc.ThriftModule(
rpc.CreateThriftServiceFunc(NewYarpcThriftHandler),
modules.WithName("keyvalue"),
),
).Buil…
-
as long as they are used in public functions, they should be public IMO.
-
Looks like for a project that only has uberfx in its glide.yaml, that glide is not respecting fx's requirements in it's own glide.yaml.
From the current fx master `e0c5d60f3dba78297ff20b61ba1626def…
-
I'd suggest to add the `f` variants of the logger.
```go
log.Infof("hello %v", world)
```
or find a way to make this possible in k:v
```go
log.Infof("debug", "world %+v", foo, "bar %q", ba…
-
Just want open a discussion about:
```
// Handler is a context-aware extension of http.Handler.
type Handler interface {
ServeHTTP(ctx context.Context, w http.ResponseWriter, r *http.Request)
}…
-
In order for extension authors to implement authz/n middleware, as in https://github.com/uber-go/fx/pull/145, they'll need to be able to return either a authn or authz error that is defined and unders…
-
I want to get some sense of how people would feel about this - note I'd advocate keep an open mind, as if this scares you, it probably won't after using it for a bit, but want to get some feedback her…
-
With the current [implementation](https://github.com/uber-go/fx/blob/master/core/ulog/log.go#L141-L144) we can get runtime errors ... for logging. Even if more verbose I'd follow the `withFields` thin…
-
Following up our discussion yesterday: I would like to propose the following:
- `fx.Context` is a struct that embeds `context.Context` rather than an
interface.
- UberFx values stored on …
-
refer to this: https://github.com/uber-go/fx/blob/master/modules/uhttp/health.go#L32
I like the idea behind our internal gocommon health package. When we used it, we made some twists.
1. instead o…