-
Your HTML is looking pretty good so far. One very important thing to keep in mind is that you must always use relative paths for resources such as images or stylesheets vs. an absolute path.
https…
-
Great! Nice work with the consistent nesting and indentation in your HTML. This helps with the organization and readability of your markup. I especially love your use of comments at the beginning and…
-
There are a few suggestions that you might want to make to possible improve the readability of your CSS code. Try to reduce the number of empty lines in the code. You usually just need a single empty …
-
Grade: Exceeds expectations
Summary: Really nice job on this project, the site looks very good. You used a lot of good techniques and kept your code well organized. I created a couple issues with s…
-
Great job using media queries to display your mobile navbar in a proper way
https://github.com/skiran85/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademy/index.html#L47-L57
-
https://github.com/Charn293/f1-3-c2p1-colmar-academy/blob/077cb33fcaa47108d71b90ace2234d70a0ccc2be/Colmar/resources/css/style.css#L386
You are writing this a few times. This can lead to being lost…
-
Your CSS looks good. Well organized and good naming conventions.
https://github.com/kasim0225/Colmar-Academy/blob/master/resources/css/style.css
-
Excellent job using variables for the different colors used!
https://github.com/pollysiegel/colmar-academy/blob/f824f4f1aa5b28fe4661da4f2241e47736a5b8ce/resources/css/style.css#L4-L15
-
https://github.com/SShapiro1/Colmar_Academy/blob/master/index.html#L9-L11
Line up your links to be aligned and maintaining clean markup.
-
When using the ampersand character remember to use it's character entity reference
https://github.com/rblancobarbara/Colmar-Academy/blob/4cab8d14ccdb411aa74d8b24ffd1baac9140c078/index.html#L212`