-
I find this library sort the hashed leafs two pairs only:
```
func concatSortHash(b1 []byte, b2 []byte) []byte {
if bytes.Compare(b1, b2) < 0 {
return concatHash(b1, b2)
}
return concatHash…
-
`safeAdd`, `safeSub`, `safeMul`, `safeDiv` could be imported from openzeppelin `SafeMath` instead of rewriting them
-
**🧐 Motivation**
My concern is whether it is reasonable to forcibly generate a new `ProxyAdmin` in the constructor of `TransparentUpgradeableProxy.sol`:
**📝 Details**
https://github.com/OpenZeppe…
-
> The original proxies included in OpenZeppelin followed the Transparent Proxy Pattern. While this pattern is still provided, our recommendation is now shifting towards UUPS proxies, which are both li…
-
Check if its possible to improve the gas consumption for `canCallWithDelay`. Currently every call to this method uses ~14k gas. Since this is often done multiple times during an operation, an improvem…
-
From https://wizard.openzeppelin.com/#erc721, enable "Mintable -> Auto Increment Ids" and "Upgradeability". This adds state variable `uint256 private _nextTokenId;`to the code, and this can be enhan…
-
### Description
For compatibility with the zkp2p Notary node, we will use Ethereum keys when signing messages.
Reimplement [this](https://github.com/zkp2p/zk-p2p/blob/28614160b5f1320c4b866ee41…
-
### Component
Forge
### Have you ensured that all of these are up to date?
- [X] Foundry
- [X] Foundryup
### What version of Foundry are you on?
forge 0.2.0 (9e3ab9b 2024-01-04T00:18:0…
-
### Component
Forge
### Have you ensured that all of these are up to date?
- [X] Foundry
- [X] Foundryup
### What version of Foundry are you on?
master
### What command(s) is the bu…
-
Good Day,
after declaring license comment //SPDX follow by the solidity compiler version and import statement from openzeppelin github repository declare your constructor and its arguement.
The…