-
Almost in all instance where we use raw multihash we find ourselves capturing payload size an the side. It is also probably worth calling the fact that somewhat recently [fr32-sha2-256-trunc254-padded…
-
Reading the spec I noticed that the code blocks in the beginning show a pseudo-wire protocol representation by just showing the contents of each message without explicitly showing the varint message l…
-
I don't know if this is incorrect, (this is my first time using github)
It seams that as in 1.18 the way of unpacking chunks has changed vs what is used in the official 1.18 release of this project…
-
Currently column idx are u16 and field lengths (for Strings, Binary, etc.) are u32. I expect in practice that column indexes would almost always fit in a 1 byte varint and field lengths typically in …
-
We use varints in a few "internal" places in the encoding for Value.
- Level (the depth of the prollytree)
- Count/Len of entries in a sequence
- Length of strings
One reason we did this was b…
-
### What happened?
Another bug found while adding type-hints. `BytesIO.write()` does not accept an int, which is always the result of subscripting a `bytearray`. There does not seem to be any unit …
-
I'd like to see several improvements to Testworks output:
- [ ] An option to display no progress output except for failing tests. `--progress failures` I suppose. i.e., don't display pass, not impl…
-
We just got a crash on psbt target. `rust-miniscript` successfully deserializes a PSBT while Bitcoin Core fails due to `ReadCompactSize(): size too large`. This failure happens during key type checkin…
-
>So what? If it defines a trait that should be potentially public and global for the ecosystem
Maybe. It looks like the usage in #2929 comes from two places: one is
> I only partially agree her…
-
Reviewing the following code:
![image](https://user-images.githubusercontent.com/4958833/50028158-5597ad80-ffb4-11e8-97f3-8223c4bb1e9a.png)
and the generated assembly:
varint_bench_test.g…