-
# Rust API Guidelines Checklist
- **Naming** *(crate aligns with Rust naming conventions)*
- ~[ ] Casing conforms to RFC 430 ([C-CASE])~
- [ ] Ad-hoc conversions follow `as_`, `to_`, `into_` …
-
In https://github.com/rust-bitcoin/rust-miniscript/blob/master/src/psbt/finalizer.rs we have code like
```rust
} else if script_pubkey.is_p2pkh() {
// 2. `Pkh`: creates a `PkH` descri…
-
We're expecting testnet4 to launch in the coming months and be a part of the next Bitcoin Core release. PR is here: https://github.com/bitcoin/bitcoin/pull/29775
jlopp updated
4 weeks ago
-
Is this still TODO?
I gather that rust-bitcoin is trying to remove the NetworkValidation complexity from Address, so this isn't supercritical to get perfect on the first pass. It can …
-
I guess I understand why but it's a part of public API and looks fragile, it should be no possibility to construct such invalid input
https://github.com/rust-bitcoin/rust-bitcoin/blob/d8e94cf181769…
-
We should split rust-miniscript into two repos, `rust-descriptors` and `rust-bitcoin-script`. Then we can have stricter types on `Script` and bring the `ScriptContext` trait into rust-bitcoin.
rus…
-
I'm kinda out of the loop on this but I might read it more later.
> API BREAKING CHANGE DETECTED
I much prefer the alerts vs the CI breakage and the diff being stuffed into git. A…
-
https://github.com/rust-bitcoin/rust-bitcoin/pull/1962
https://github.com/rust-bitcoin/rust-bitcoin/issues/1424
-
This is a tracking PR for the mess that has been uncovered in the `pow` module. The main problem can be distilled by this quote (referring to the `Target::MAX` constant):
> To be more specific: thi…
-
In the utill.rs file, there are several functions that perform tasks for which APIs already exist in the dependency libraries.
For example
https://github.com/citadel-tech/coinswap/blob/691c937454c…