-
I remember there were some patterns that were not possible due to that (maybe @Maan2003 remembers).
Two possible (somewhat orthogonal) things we could do:
First, make `commit_tx` take `&mut self…
-
Whenever we're displaying txid, it's not immediately clear if it's Bitcoin's of Fedimint's txid, which was rather confusing when I was getting peg-in transaction (since L1 tx is actually being passed)…
-
What type should distributedgen's `announce-address` type be? https://github.com/fedimint/fedimint/blob/d5c2295d3ae3d8c26f75ad2aa287a46ae5f57c62/fedimintd/src/bin/distributedgen.rs#L47
It's current…
-
- [ ] [Unused macro arguments](https://github.com/fedimint/fedimint/pull/1748#pullrequestreview-1312726737)
- [ ] [Unused error enum variants](https://github.com/fedimint/fedimint/pull/1718/commits/3…
-
We should try to compile `fedimint` for ARM and try to run a federation on Raspberry Pis.
-
Unrelated to this PR: The naming is a bit weird. Why does a **base** port change (it does I assume since it's an atomic int)?
_Originally posted by @elsirion in https://github.com/fedimint/…
-
We trust and use `bitcoin-rust` code anyway, so by not using hex, we could get rid of one dependency.
And also `hex` doesn't seem to be able to write stuff out without allocating, while `bitcoin_ha…
-
Currently we use the following JSON encoding to allow clients to "join a federation":
```
{"members":[[0,"wss://fm-signet.sirion.io:443"]],"max_evil":0}
```
This basically just JSON-encodes th…
-
We just experienced a panic in a live deployment on this line:
https://github.com/fedimint/fedimint/blob/73d851fc208f4bb0dadd65c148800a9c753a30d7/fedimint-server/src/consensus/mod.rs#L320
```
J…
-
A couple months ago we decided to get rid of "coin" and "token" terminology in favor of "note". But now we use all 3 terms in the codebase which is even worse. I imagine this could be very confusing t…