-
1. Нарушение БЭМ !!!
Что делает в файле `modal.scss` код стилей других блоков? https://github.com/MrRobot-p/Meine-coon/blob/534eb7b2243742b29a9cb949b18d8a5fcb43a357/src/scss/components/modal/modal.sc…
-
Нарушено единообразное написание кода
Пример:
https://github.com/MrRobot-p/Meine-coon/blob/ee10dd3b3572c47d6854e99ea716f7b67990d370/src/scss/components/modal/modal.scss#L76-L79
и
https://github.co…
-
* The link to your script file appears twice:
https://github.com/FACN3/project_mrrobot/blob/master/index.html#L35
https://github.com/FACN3/project_mrrobot/blob/master/index.html#L41
* It is a goo…
-
Vulnhub boxes are downloaded as Virtual Box ova's.
Should be able to grab the disk file and convert to raw using qemu image-convert. Simon has some docs and limited experience with this.
Then sh…
-
https://github.com/MrRobot-p/Meine-coon/blob/ee10dd3b3572c47d6854e99ea716f7b67990d370/src/scss/components/features/features.scss#L18
-
What's this comment for? https://github.com/FACN3/project_mrrobot/blob/master/style.css#L108
-
e.g. https://github.com/FACN3/project_mrrobot/blob/master/index.html#L155
makes it harder to read your code
-
Анимации рекомендуется выносить в отдельный файл в папку `base`
https://github.com/MrRobot-p/Meine-coon/blob/534eb7b2243742b29a9cb949b18d8a5fcb43a357/src/scss/components/feedback/feedback.scss#L194-L…
-
https://github.com/MrRobot-p/Meine-coon/blob/ee10dd3b3572c47d6854e99ea716f7b67990d370/src/scss/components/overlay/overlay.scss#L7
Указывать высоту в процентах весьма опасно!
Гораздо лучше подойдет `…
-
We want to be able to test latest AppFlow code based on [Continuous Integration](https://en.wikipedia.org/wiki/Continuous_integration) via Jenkins.
The basic idea is to run Jenkins inside a Docker co…