In a furnace: "Steel or Non-Steel?"

[BarchamMal]

Your setup Device platform: MacOS Game version: Same as all my issues. SERVER SIDE!

Describe the bug If you have charcoal and non-steel ores (salt, copper, iron, mithril) in a furnace, they will not smelt. Logical error I think. I wonder if the code goes like this:

if forge.inventory.has_item(charcoal):
    for item in forge.inventory:
        forge.try_to_smelt_recipe(item, charcoal)
else:
    for item in forge.inventory:
        forge.try_to_smelt_recipe(item)

When it should be:

if forge.inventory.has_item(charcoal):
    for item in forge.inventory:
        if not forge.try_to_smelt_recipe(item, charcoal):
            forge.try_to_smelt_recipe(item)
else:
    for item in forge.inventory:
        forge.try_to_smelt_recipe(item)

To Reproduce

1. Put wood in a furnace to heat it up.
2. After it is heated, put charcoal and iron in the furnace.
3. The furnace will cool back down and nothing will get smelted.

[Samuel-IH]

@BarchamMal we need to get you on discord so you can join the team. I swear C# is like Java but better!

[BarchamMal]

that was python.

[Samuel-IH]

Obviously. But I know you know Java.

[BarchamMal]

Oh good.

[BarchamMal]

Was my guess correct?

[Samuel-IH]

No. Charcoal is just part of the recipe.

[BarchamMal]

Then why doesn't iron, salt, or copper smelt when charcoal is in the furnace?

[Samuel-IH]

It was an iteration issue. Looping through an inventory while I'm already looping through the same inventory. Interop stuff.