A-Metaphysical-Drama / LoL-Linux-Tools

A small tool to edit League of Legends files in linux
http://metaphysical.zz.mu/
GNU General Public License v2.0
36 stars 26 forks source link

3.11 Update #4

Closed jacobmischka closed 11 years ago

jacobmischka commented 11 years ago

The 3.11 update broke pretty much all "addons" for the game, this package included.

I originally was playing on a rather old install of LoL that had the patch applied already a few times and had been working pretty well. As of this patch, the edited files cause the game to bugsplat immediately after champion select. So I figured I should just reinstall everything to see if that fixes any problems.

I'm using a brand new copy of LoL-Linux-Tools that I downloaded moments ago, and just ran a complete reinstall of League of Legends into a brand new wineprefix. The game at least doesn't crash immediately anymore, just of course when opening the shop.

When trying to run the texture patch, I get the following error:

Wrong Path: DATA/Characters/TT_OrderInhibitor/TT_OrderInhibitor.inibin DATA/Characters/Talon/Talon.inibin

I'm not sure why it expects those two items to be the same, but there you go.

I did notice that you were incredibly fast in updating the DATA tarball though, so thank you for that.

And thank you very much for the work you've done on this project. You've helped many, many people.

<3

jacobmischka commented 11 years ago

Oh, I just noticed that you have been participating on http://appdb.winehq.org/objectManager.php?sClass=version&iId=19141&iTestingId=79830, so I guess you already know about any issues regarding the new patch.

I am aware that patching wine fixes the crash resulting in ugly red squares which can then be fixed with this patch, but I would rather not have to patch wine if your script will fix it as well. I'm using stable wine1.6 right now.

Thank you again!

A-Metaphysical-Drama commented 11 years ago

Hi, for some reason, patching the textures with the 3.11 patch makes them all invisible, so using just a patched wine is the best solution right now.

I'm investigating the issues, any help is welcome!

jacobmischka commented 11 years ago

I'll help in any way I can, please let me know if there's anything you would like done. I don't know much about python though, unfortunately, but I'll be happy to test anything you would like.

Eremiell commented 11 years ago

I'm getting "File not found in releasemanifest, patch could not be applied." since 3.11. When I added print(filename) before the error, I get "3210_Instigator.dds". I'm not sure, what that means, as I haven't yet digged deeper into LoL files, if it's part of the same problem or not. Also the file does not seem to be inside the DATA.tar.gz. Tried manually putting backups back in, didn't change a thing. Thanks for your great effort.

A-Metaphysical-Drama commented 11 years ago

Don't patch LoL with my tool Run a repair, then patch wine with the hack ( http://uz.sns.it/~ranma42/iLoL/0001-HACK-Disallow-block-based-textures-with-sub-block-si.patch ) and run LoL

This is the best solution yet, i'm working on something better, but is not that easy

Eremiell commented 11 years ago

I have that patch applied, since I installed LoL using the install script from winehq appdb. Still it was your fixtool, which made it working for me before, having problems with both shop and red icons without it.

tarokkk commented 11 years ago

With fresh install and PlayOnLinux latest Wine-LoL (1.7) works well but the red icons came back. If you have time I would read about the cause of this problem and help with it. I'm a software enginer but not familiar with textures and 3d softwares. What is the difference between red and working icons?

jacobmischka commented 11 years ago

@tarokkk The difference is the broken red ones are mipmapped in such a way that wine can't view them. This patch modifies those images to ones that wine can read (I'm not sure exactly the specifics, @A-Metaphysical-Drama will have to fill you in there, or you can just check out the code). The problem is that with 3.11 the game crashes with any custom textures, so the patch no longer works.

The problem introduced with 3.11 has nothing to do with wine at all. Even if you're on windows, any unofficial textures will result in a crash right now. Riot is apparently reaching out to its most popular modders with ways to make their mods work with the new patch, hopefully once those mods/addons are updated to work again we'll have some clue on how to change the images without the game crashing.

jacobmischka commented 11 years ago

Also, accidentally closed instead of just commenting, my bad.

A-Metaphysical-Drama commented 11 years ago

My patch should work fine now! Thanks to https://bitbucket.org/Xargoth/tuxlol/wiki/Home i patched textures in a different way (Changing just 1 byte)

jacobmischka commented 11 years ago

Awesome, thank you! Confirmed working for me, no crashes/bugsplats and no red squares!