Closed DuckyCrayfish closed 2 years ago
It will be better if I add option to the config. Something like "AlwaysShowButtons = Mute, Solo, Mono". I'm not sure about moving these buttons under the fader. My intention was to make it looks similar to Voicemeeter, and because of A1-B3 buttons on inputs it may not look "uniformly".
It will be better if I add option to the config. Something like "AlwaysShowButtons = Mute, Solo, Mono".
Good call, a config option for this would be smart.
However, an "AlwaysShowButtons" option would imply that the mute button would show after changes in every type of parameter (for example, changing A1-A5 or Solo/Mono), instead of just gain changes. Is this what you would prefer? If not, an alternative setting could be "ShowMuteOnGainChange = False".
I'm not sure about moving these buttons under the fader. My intention was to make it looks similar to Voicemeeter
That makes sense, I did not notice that if matched the style of Voicemeeter. Would you settle on having it above the gain fader, similar to output busses in Voicemeeter? (see image). In my opinion it looks much neater when only 1 column is needed for both mute and gain. It could possibly go in the same container as the "Sel" button.
Here's an update after moving the mute button to under the SEL button. I personally prefer my original proposed location as I already found the SEL button to look a bit sloppy up top, but I understand where you're coming from.
Original proposal: New proposal:
"AlwaysShowButtons" Is more universal, because it follows this logic: you see difference but don't hear difference because Mute button is not visible. But if Mute is always visible you don't need to remember that this particular Strip is muted and any changes has no "audible" effect. It can be applied to not only Gain but also to Mono and Bus assign changes. Also user might want to see other buttons so I added Options for it in recent commits just in case.
Regarding buttons position: I prefer to put all buttons to the right side of the Fader (maybe I should move SEL button too, there is enough place for it), and to have more or less consistent layout for all inputs and outputs. Because if there was only 3 buttons (Mono, Solo, Mute) it would be fine to place them on the bottom, but there are up to 8 Bus assign buttons, if both "control" buttons and Bus buttons are visible it can create huge empty space (if Fader's height is not low enough and I'm talking only about Potato version). Still I might experiment a little, ask some friends what they think and change it (move these 3 buttons to the bottom).
Also because of some "difficulties" with Options and the way OSD is updated in code I don really need this Pull Request, I have to implement it myself.
Thank you for your consideration and for adding the new option.
I personally use FancyOSD as a volume-slider for Voicemeeter. It can be confusing to show volume adjustments on a muted bus without showing the mute button, as the current fader style can give the impression that the bus is not muted.
This pull changes the mute button visibility conditions so that changes in gain will trigger the mute button to display as well.
Here is the resulting appearance: