search

A11v1r15 / Skull_vision

A simple client-side Minecraft mod that allows you to see like a mob when wearing it's skull
MIT License
1 stars 1 forks source link

only vanilla mob heads render shaders with Just Mob Heads #1

Closed steve-the-player closed 1 month ago

steve-the-player commented 10 months ago

I'm using Just Mob Heads by Serilium, which functions similarly to the vanillatweaks mob head datapack, but the heads it generates don't play mob sounds when placed on a noteblock. According to your datapack file at /src/main/resources/assets/data/minecraft/tags/items/noteblock_top_instruments.json, only mob heads which have been added to that category and play sounds when the head is placed on top of a noteblock will generate mob head shaders.

A11v1r15 commented 10 months ago

I'm still deciding what I should do in regard to this. I'd rather have Serilium to fix their mod, since it would also make it a better mod and it already has it as an issue

steve-the-player commented 10 months ago

Ah. Well, in the meantime, do you have any other mobhead datapacks/mods you can recommend? I've tried Headed, but it has multiple known issues where the game crashes or freezes, and also doesn't appear to add the noteblock_top_instruments tag (oh wait, I just noticed, you were the one that submitted that bug report, heh)

A11v1r15 commented 10 months ago

Unfortunately, I only know of these 3 (Serilium's, headed and vanilla tweaks'), if you find more of them, please let me know.

A11v1r15 commented 10 months ago

I just sent a pull request to Serilium, I hope he accepts or at least get the code modifications I did and commit them himself

ricksouth commented 3 months ago

Sorry it took me so long to get to. I also lost track of the PR when I moved to separate sources for each mod.

I have just uploaded version 8.1 of Just Mob Heads which adds compatibility with note blocks. Thank you @A11v1r15 for the work!