[New] add implicit role of `graphics-document` to `svg` element

A11yance / aria-query

Programmatic access to the ARIA specification

Apache License 2.0

275 stars 43 forks source link

[New] add implicit role of `graphics-document` to `svg` element #548

Closed jlp-craigmorten closed 1 week ago

jlp-craigmorten commented 6 months ago

Fixes #181 Supports https://github.com/testing-library/dom-testing-library/issues/1295

See relevant specifications:

Does not address other element role mappings laid out in SVG-AAM.

codesandbox-ci[bot] commented 6 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 9835386926

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.491%

Totals
Change from base Build 9833640894:	0.0%
Covered Lines:	285
Relevant Lines:	289

💛 - Coveralls

jlp-craigmorten commented 3 weeks ago

P.S. @ljharb not sure CI is running tests correctly, seeing...

Run npm run tests-built

> aria-query@5.3.1 tests-built
> nyc tape '__tests-built__/**/*.js'

TAP version 13

1..0
# tests 0
# pass  0

# ok

Indicating things may be passing incorrectly (indeed I managed to get an incorrect pass just now on this branch despite messing up the rebase and having tests failing locally)

If have time later I'm happy to try take a look and try fixup in a separate change (though suspect you'll sort it out far quicker).

ljharb commented 3 weeks ago

I’ll take a look at that, thanks.

ljharb commented 2 weeks ago

k, test issues resolved, and this PR has been rebased.