fix: update role `none` to match role `presentation`, update role `doc-pullquote` to match specification

A11yance / aria-query

Programmatic access to the ARIA specification

Apache License 2.0

275 stars 43 forks source link

fix: update role `none` to match role `presentation`, update role `doc-pullquote` to match specification #551

Open huynhducduy opened 5 months ago

huynhducduy commented 5 months ago

Description

Role none introduced as a synonym to presentation role, thus must have the same configuration as presentation role.
Based on DPub-ARIA 1.1, role doc-pullquote incorrectedly have superClass of none, which should be section

Sumary of changes

Update configuration of role none to match role presentation
Add tests for role none to be the same as role presentation's tests
Update superClass of doc-pullquote to section instead of none

codesandbox-ci[bot] commented 5 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

ljharb commented 2 months ago

tests appear to be failing

jlp-craigmorten commented 2 months ago

Worth noting the "update role doc-pullquote to match specification" aspect of this change is as a result of differences between versions 1.0 and 1.1 of the DPUB-ARIA specification, see:

In addition to the superclass role, there are also differences in the listed "inherited states and properties".

Assuming aria-query was based off of the 1.0 spec (a reasonable assumption given it's reflection), this should be considered a breaking change.