A2-Collaboration / ant

Just another analysis toolkit for A2
3 stars 20 forks source link

Implement TaggEff as SlowControl variable #48

Closed neiser closed 7 years ago

neiser commented 7 years ago

As described in #45, this pull request implements passing tagging efficiencies as TSlowControl to the physics classes, via proper processors/variables. Using the detector interface is not working due to the intermediate buffering.

TODO:

Feel free to push fixes on top of the branch A2-dev/fixed-taggeff

codecov-io commented 7 years ago

Codecov Report

Merging #48 into master will decrease coverage by 3.23%. The diff coverage is 42.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   47.97%   44.73%   -3.24%     
==========================================
  Files         528      532       +4     
  Lines       28397    28440      +43     
  Branches     1101     1101              
==========================================
- Hits        13623    12723     -900     
- Misses      14280    15223     +943     
  Partials      494      494
Impacted Files Coverage Δ
src/expconfig/detectors/Tagger.h 76.92% <ø> (+10.25%) :arrow_up:
src/expconfig/detectors/EPT.h 100% <ø> (+9.52%) :arrow_up:
src/analysis/slowcontrol/variables/Beam.h 100% <ø> (ø) :arrow_up:
src/analysis/slowcontrol/variables/Beam.cc 33.33% <0%> (-44.45%) :arrow_down:
...nalysis/physics/scratch/collicott/cross_section.cc 32.69% <0%> (-43.78%) :arrow_down:
src/analysis/slowcontrol/SlowControlProcessors.cc 100% <100%> (ø) :arrow_up:
src/analysis/physics/common/PhotonFlux.cc 64.38% <100%> (-25.9%) :arrow_down:
...ysis/slowcontrol/processors/AcquScalerProcessor.cc 95.83% <100%> (+0.37%) :arrow_up:
src/analysis/slowcontrol/SlowControlVariables.cc 100% <100%> (ø) :arrow_up:
src/analysis/slowcontrol/processors/TaggEff.h 100% <100%> (ø)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d87217b...bfd44af. Read the comment docs.