[Feature Request]: Update Guice

A248 / LibertyBans

The be-all, end-all of discipline.

https://ci.hahota.net:8443/job/LibertyBans/

GNU Affero General Public License v3.0

169 stars 41 forks source link

[Feature Request]: Update Guice #274

Closed BAD7777 closed 3 months ago

BAD7777 commented 3 months ago

I have confirmed that ...

[X] There is no duplicate feature request.

Description

I noticed that the project is using an older version of Guice (6.0.0), which utilizes deprecated JavaX annotations. To avoid potential compatibility issues and to take advantage of new features and improvements, I suggest updating Guice to a newer version.

A248 commented 3 months ago

We don't use Guice at all; rather, we use Jakarta annotations with a simpler injector library.

A248 commented 3 months ago

Okay just to clarify: Velocity uses Guice to instantiate plugins. LibertyBans itself doesn't use Guice. However, the entry point for the velocity platform implementation uses javax.inject in 1 class and exactly 1 class, and that's to enable Velocity to instantiate it.