search

A3Antistasi / A3-Antistasi

A3-Antistasi is the new official Antistasi version
https://a3antistasi.enjin.com/
MIT License
79 stars 334 forks source link

Why entering the local variable _nul to never use it again? #180

Open AlexTriada opened 5 years ago

AlexTriada commented 5 years ago

dear Barbolani _nul and null - is not special variables _nul = [] spawn , _nul = [] execVM, etc - you entering local variable to never use it you 237s "_nul = ..." is wrong, if you not using variable _nul in check, delete it pls)

AlexTriada commented 5 years ago

and "null = ..." wrong too, if you not using variable null in check

Barbolani77 commented 5 years ago

Will check it. Most of those _nul = come from oldschool scripting, old script copypastes etc.. It's not a big deal, that kind of thing is very cheap for the memory / cpu, and for debugging purposes sometimes is useful (you may check return variables or scriptDone command)

AlexTriada commented 5 years ago

"and for debugging purposes sometimes is useful" - this is if you use variables unique, not the same 237 times

AlexTriada commented 5 years ago

can I help you with this, with merge requests?

AlexTriada commented 5 years ago

and in general, your programming style is terrible, have you thought about how to bring your code in order?

Barbolani77 commented 5 years ago

I may be terrible, but again, for your personal opinions I think this is not the place. The code is in order, without order it wouldn't work.

If you want to replace the code with a functional, non-terrible program with the same functionalities and better performance, this is the place, post it and explain it for terrible programmers so we will be able to provide support in future.

This terrible programmer also knows that if you spawn a function with "_nul = [] spawn.." after that you may do something like "waitUntil {scriptDone _nul}" or if you call the function with "_nul = [] call..." you may check the function return with "If (_nul)", and it doesent matter you name it _nul, _nil or _betterSpendYourTimeOnConstructivePeople as long as they are private variables which won't be affected by anything if there are no other variables with this name spawned in the same scope.

I also know removing this won't have any micro-even noticeable impact on nothing, so I will do, no worries, but I have other priorities.

I don't think your mood is still the right. You still persist on spamming on extremely unrelevant things and making personal comments.

If you continue, I suggest you to leave and build your own mission with your superior skills, but your own please, Im tired of super clever programmers that just fork my work and modify it to leave it with no success. You would be like the seventh.

AlexTriada commented 5 years ago

Dude, you're always in your repertoire, variables nul do not apply to my statement that the code is terrible), it's strange that you do not admit your mistakes and perceive everything with hostility, but apparently you do not fix, and I did not want to. I'll try to start sending you my changes, what will be the reaction I guess, but I'll try to take a chance) don't take all the hostility, reduce the degree, I'm your friend and not the enemy)

AlexTriada commented 5 years ago

"after that you may do ..." - and there can be placed a submarine, but it's not there)

Barbolani77 commented 5 years ago

Alex, if you speak this way to your friends, I don't want to think how you do with the others.

In none of my replies I said those variables are not a mistake, they are indeed, and I explained you why are still there, and also the extremely low impact of removing them. If you take your time to remove them, it's welcome.

Barbolani77 commented 5 years ago

And proof of thinking they shouldnt be in the code it's I didn't close the issue, isn't it?

AlexTriada commented 5 years ago

"The code is in order, without order it wouldn't work."- read this book: https://github.com/edgarordonez/books/blob/master/Code/The%20Robert%20C.%20Martin%20Clean%20Code%20Collection%20-%20Robert%20C.%20Martin.epub

AlexTriada commented 5 years ago

"If you continue, I suggest you to leave and build your own mission with your superior skills, but your own please, Im tired of super clever programmers that just fork my work and modify it to leave it with no success. You would be like the seventh."

AlexTriada commented 5 years ago

"super clever programmers that just fork my work and modify it to leave it with no success"

Barbolani77 commented 5 years ago

Alex, Im really tired of your personal opinions about how I manage bug reporting.

There are a few people contributing here and spotting bugs with no issues at all, it's only you the one who is continuously saying I have problems with people doing so.

I reviewed all your posts:

As main developer of this mission I have limited time for Antistasi, and all that time has to be maximized on focusing on real issues and feature development. Wasting 15 minutes in your personal impressions, is not helping Antistasi or the code itself if it's in change of one bug that sooner or later would have been spotted.

That's the reason of blocking you. You are definetly trolling this thing. I don't care how many times you say "I want to help".

Jonathan-Rosewood commented 5 years ago

You say quite the right things, but the code is really terrible. Templates mechanisms, missions, directory structure, local parts of the code sometimes cause serious problems in understanding and reading. By the way, it primarily slows down third-party developers to contribute.

In none of my replies I said those variables are not a mistake, they are indeed, and I explained you why are still there, and also the extremely low impact of removing them. If you take your time to remove them, it's welcome.

Ha, are you talking about time? How many times during the entire existence of these variables did people spend precious time waiting for the mission to load (initialize)? First of all, I'm talking about developers who have contributed to the mission. At the moment, I am watching 203 commits. Presumably, for each it took to load the mission at least 3 times. Let these variables change the boot time by an average of 1000 milliseconds. At the output we get 609 seconds (10 minutes) of the time spent waiting. How long will it take to fix this problem (deleting variables)? In 10 minutes, this will be done by a first-year student who first saw the code, if he was correctly assigned a task and given a tool for this.

lsvalmont commented 5 years ago

It is funny guys how you criticize Barbolani77's coding while none other in the whole community has done anything remotely similar or as good as Antistasi. Being a coder for more than 5 years now I can tell you that not documenting code or using two languages when writing code does not translate into bad coding... Bad performance and bugs = Bad coding! And for most players Antistasi runs very well and might even have fewer bugs compared to official BI missions even thou Antistasi's scope is HUGE!

Barbolani, it all comes down to readability of your code for these guys, of course it makes it harder for new coders to understand code if it is uncommented and/or mixed with spanish. Luckily I understand spanish and therefore I can read all your code perfectly.

To AlexTriada and friends: You are not being helpful, you are not contributing and what is worst you are actually lying when you label hard and good work as "bad code" when the correct term would be "bad/hard readability" in the code and not bad code. Bad code is what BI did with DayZ stand alone! =)