search

AAClause / BrailleExtender

NVDA add-on that improves braille support
https://andreabc.net/projects/NVDA_addons/BrailleExtender/
GNU General Public License v2.0
16 stars 17 forks source link

Add Toggle mouse emulation with arrow keys when routing cursor #21

Closed daniel-1964 closed 6 years ago

daniel-1964 commented 6 years ago

Fixes #20 Some console applications handle mouse. If mouse emulation with arrow keys is enabled theses applications stop to work correctly.

AAClause commented 6 years ago

First of all, congratulation for your first pull request! Especially since my code is not very Readable and elegant. :) Thanks! Concerning the text label in general settings, I will suggest something like that "Try to emulate keyboard movements via routing cursors" rather than "Emulates mouse with arrow keys". What do you think?

daniel-1964 commented 6 years ago

OK thanks for your review. I will made the change and update the French translation.

AAClause commented 6 years ago

Sorry... I think that "Try to emulate horizontal arrow keys with routing cursors in review mode" is still better. Also, concerning key in config file, instead of "emulateMouse" I'll suggest "routingReviewMode". Note that this feature is still not very reliable. Thanks.

daniel-1964 commented 6 years ago

Hi, Finally something like routewithcursorkeys should be fine. A gui label like Use cursor keys to route cursor could also be good enough no?

AAClause commented 6 years ago

A gui label like Use cursor keys to route cursor could also be good enough no?

Yes, I think. But specify "in review mode", it is important.

AAClause commented 6 years ago

Thanks again for this work! One final point: what name should I use for you in authors / acknowledgments list?

daniel-1964 commented 6 years ago

Euh you can use my own name "Daniel COTTO" if you want.