search

AAClause / BrailleExtender

NVDA add-on that improves braille support
https://andreabc.net/projects/NVDA_addons/BrailleExtender/
GNU General Public License v2.0
16 stars 17 forks source link

Integrate portions of braille extender into NVDA core #31

Open LeonarddeR opened 5 years ago

LeonarddeR commented 5 years ago

I believe braille extender has primarily been developed to overcome shortcomings in NVDA core with regard to braille support. As a member of the NVDA Council who uses braille on a daily basis and lives in a country where braille support is important, I believe that some of its features really belong into the core of a screen reader.

Therefore, I think this issue might be a good platform to start discussing the what, the why and the how about issues that should be ported or integrated into the core of NVDA. We can also have this discussion on the NVDA development list or the add-ons list, but I"m afraid it will make the discussion too scattered and cluttered.

I believe the following Braille Extender features deserve to have a place in NVDA's core base:

cc @Andre9642 @zstanecic @Adriani90 @josephsl

zstanecic commented 5 years ago

Hi to all,

I think that it is ok.

I am also voting for the more extended gesture profiles to be imported in NVDA core.

For now we have eurobraille, handytech brailliant and freedom scientific profiles.

From: Leonard de Ruijter notifications@github.com Sent: Friday, January 25, 2019 8:10 AM To: Andre9642/BrailleExtender BrailleExtender@noreply.github.com Cc: zstanecic zvonimirek222@yandex.com; Mention mention@noreply.github.com Subject: [Andre9642/BrailleExtender] Integrate portions of braille extender into NVDA core (#31)

I believe braille extender has primarily been developed to overcome shortcomings in NVDA core with regard to braille support. As a member of the NVDA Council who uses braille on a daily basis and lives in a country where braille support is important, I believe that some of its features really belong into the core of a screen reader.

Therefore, I think this issue might be a good platform to start discussing the what, the why and the how about issues that should be ported or integrated into the core of NVDA. We can also have this discussion on the NVDA development list or the add-ons list, but I"m afraid it will make the discussion too scattered and cluttered.

I believe the following Braille Extender features deserve to have a place in NVDA's core base:

cc @Andre9642 https://github.com/Andre9642 @zstanecic https://github.com/zstanecic @Adriani90 https://github.com/Adriani90 @josephsl https://github.com/josephsl

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Andre9642/BrailleExtender/issues/31 , or mute the thread https://github.com/notifications/unsubscribe-auth/AKohk0a0vqZh1JU8HL5iv1ctAApIm9kjks5vGq3IgaJpZM4aSUq5 . https://github.com/notifications/beacon/AKohk5IKEISFYZGp8rdxKRoItjrjqVvBks5vGq3IgaJpZM4aSUq5.gif

AAClause commented 5 years ago

@leonardder No problem for me! I'd like to contribute more to NVDA Core. However, I'm afraid because my code is not very clean. This add-on was created 4 years ago. I learned Python (and I still learn) with that. :) I mainly focused on the user experience. In any case, I'll make better for pull requests in NVDA Core. I'd also add the auto scroll feature. What do you think?

@zstanecic gesture maps should be improved because there are some conflicts with gestures declared in NVDA Core especially for Freedom Scientific displays. Also, in my opinion, we should discuss the relevance of a generic gesture map for all displays with braille keyboard.

LeonarddeR commented 5 years ago

I'd also add the auto scroll feature. What do you think?

I'm a bit reluctant to add this to core. How many evidence do you have that this future is used in practice, and what are possible reasons for having it in core?

Adriani90 commented 5 years ago

< Allow reporting the character you're routing to with cursor routing commands>

There is issue nvaccess/nvda#8072.

Von: Leonard de Ruijter notifications@github.com Gesendet: Freitag, 25. Januar 2019 08:10 An: Andre9642/BrailleExtender BrailleExtender@noreply.github.com Cc: Adriani90 adriani.botez@googlemail.com; Mention mention@noreply.github.com Betreff: [Andre9642/BrailleExtender] Integrate portions of braille extender into NVDA core (#31)

I believe braille extender has primarily been developed to overcome shortcomings in NVDA core with regard to braille support. As a member of the NVDA Council who uses braille on a daily basis and lives in a country where braille support is important, I believe that some of its features really belong into the core of a screen reader.

Therefore, I think this issue might be a good platform to start discussing the what, the why and the how about issues that should be ported or integrated into the core of NVDA. We can also have this discussion on the NVDA development list or the add-ons list, but I"m afraid it will make the discussion too scattered and cluttered.

I believe the following Braille Extender features deserve to have a place in NVDA's core base:

cc @Andre9642 https://github.com/Andre9642 @zstanecic https://github.com/zstanecic @Adriani90 https://github.com/Adriani90 @josephsl https://github.com/josephsl

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Andre9642/BrailleExtender/issues/31 , or mute the thread https://github.com/notifications/unsubscribe-auth/Aaon8YSfjvpz1eEoWPdAsZnF9krtVa8Pks5vGq3IgaJpZM4aSUq5 . https://github.com/notifications/beacon/Aaon8SH8IFMfH22TMfnAQ7wazvWKfGfaks5vGq3IgaJpZM4aSUq5.gif

Adriani90 commented 5 years ago

I get also often asked if there is the possibility to use multiple braille output tables at the same time. You can use two tables at the same time with Braille extender. I think this would also be very helpful, especially for people who are reading texts in multiple languages.

Adriani90 commented 5 years ago

There are also other features whic would be very useful for braille users, but tthose are not covered in Braille extender. Let's progress with the current features first.

Adriani90 commented 5 years ago

@leonardder the autoscroll feature would be nice also, especially for braille displays for which the scrolling keys are not working or where the driver is not fully completed (i.e. the Baum Vario 80 and 64 displays. But I guess this feature is only working for braille displays which come with it implemented in their own software core. Right?

zstanecic commented 5 years ago

Hi,

We cannot do that, as with the current implementation, we’ll have only problems on imput

From: Adriani90 notifications@github.com Sent: Friday, January 25, 2019 6:58 PM To: Andre9642/BrailleExtender BrailleExtender@noreply.github.com Cc: zstanecic zvonimirek222@yandex.com; Mention mention@noreply.github.com Subject: Re: [Andre9642/BrailleExtender] Integrate portions of braille extender into NVDA core (#31)

I get also often asked if there is the possibility to use multiple braille output tables at the same time. You can use two tables at the same time with Braille extender. I think this would also be very helpful, especially for people who are reading texts in multiple languages.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Andre9642/BrailleExtender/issues/31#issuecomment-457661295 , or mute the thread https://github.com/notifications/unsubscribe-auth/AKohkxjKydIobcZ-7FUtZp6dqRDiuaguks5vG0WhgaJpZM4aSUq5 . https://github.com/notifications/beacon/AKohk8uzRvN7LAFOqjuSxtmFZ0lpXQWbks5vG0WhgaJpZM4aSUq5.gif

zstanecic commented 5 years ago

Yes, but for eurobraille i don’t have conflicts

From: André-Abush Clause notifications@github.com Sent: Friday, January 25, 2019 6:00 PM To: Andre9642/BrailleExtender BrailleExtender@noreply.github.com Cc: zstanecic zvonimirek222@yandex.com; Mention mention@noreply.github.com Subject: Re: [Andre9642/BrailleExtender] Integrate portions of braille extender into NVDA core (#31)

@leonardder https://github.com/leonardder No problem for me! I'd like to contribute more to NVDA Core. However, I'm afraid because my code is not very clean. This add-on was created 4 years ago. I learned Python (and I still learn) with that. :) I mainly focused on the user experience. In any case, I'll make better for pull requests in NVDA Core. I'd also add the auto scroll feature. What do you think?

@zstanecic https://github.com/zstanecic gesture maps should be improved because there are some conflicts with gestures declared in NVDA Core especially for Freedom Scientific displays. Also, in my opinion, we should discuss the relevance of a generic gesture map for all displays with braille keyboard.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Andre9642/BrailleExtender/issues/31#issuecomment-457641234 , or mute the thread https://github.com/notifications/unsubscribe-auth/AKohkwDpVQQpbXEdtgtQsN94I7I8hbu_ks5vGzgFgaJpZM4aSUq5 . https://github.com/notifications/beacon/AKohk3fp4oQgJqHQHPeNPFVL9HJl5dxbks5vGzgFgaJpZM4aSUq5.gif

AAClause commented 5 years ago

@leonardder Thanks for your feedback! You are probably right.

However, I think that a survey (trough Google Forms or others) should be interesting. Something like:

Question 1: in your opinion, what features of this add-on should be in NVDA Core?

Question 2: what other features would you like to see (in NVDA Core or Braille Extender itself)?

@leonardder, @zstanecic, @Adriani90, @josephsl and others: what do you think?

zstanecic commented 5 years ago

Hi to all, After a long time, i am responding... Let's create the survey and pass this around to the NVDA community... the issue will be interested also to @piciok Btw, what are plans for developing for this add-on. Can it be made compatible with Python 3? @Andre9642 I've added the latest compatibility flags, but it may break... Best, Zvonimir

AAClause commented 5 years ago

@zstanecic Thanks for your comment. Now I'm in vacation mode until september. So I'll be able to resume my GitHub activity. :) I'll try to make the survey this weekend and I'll broadcast it trough a future version of the add-on.

zstanecic commented 5 years ago

mailto:reply@reply.github.com @Andre9642/BrailleExtender

Can you make your add-on compatible with py3?

From: André-Abush Clause notifications@github.com Sent: Thursday, May 9, 2019 5:14 PM To: Andre9642/BrailleExtender BrailleExtender@noreply.github.com Cc: zstanecic zvonimirek222@yandex.com; Mention mention@noreply.github.com Subject: Re: [Andre9642/BrailleExtender] Integrate portions of braille extender into NVDA core (#31)

@zstanecic https://github.com/zstanecic Thanks for your comment. Now I'm in vacation mode until september. So I'll be able to resume my GitHub activity. :) I'll try to make the survey this weekend and I'll broadcast it trough a future version of the add-on.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Andre9642/BrailleExtender/issues/31#issuecomment-490946085 , or mute the thread https://github.com/notifications/unsubscribe-auth/ACVCDE6KFCU75SH6QAJRPMDPUQ5SJANCNFSM4GSJJK4Q . https://github.com/notifications/beacon/ACVCDE5WLVJBXMLDYQ7AY2TPUQ5SJA5CNFSM4GSJJK42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVBT4JI.gif

AAClause commented 5 years ago

Can you make your add-on compatible with py3?

Yes, I'll try to do it. Currently, I haven't had time to test Pylennium builds. Thanks

josephsl commented 4 years ago

Hello everyone,

Thanks for mentioning me a while back.

I'm looking at the history surrounding this proposal and Braille Extender source code so I can better understand what's going on and come up with a strategy to do some clean ups in preparation for making it easier for Andre to propose pull requests. I might be able to bring in experiences of maintaining Windows 10 App Essentials, Enhanced Touch Gestures, and Add-on Updater, in particular Windows 10 App Essentials as it contains many things that were eventually merged into NVDA.

As Andre pointed out, a general cleanup would be nice, and that's what I plan to do with some sort of a pull request within the next few days. This will mostly involve following Flake8's guidance and updating the add-on source code for Python idiom compliance with NVDA Core expectations (namely variable names, indentation and such). After that, I think we should discuss restructuring the add-on source code so it becomes way easier for Andre to propose pull requests. These may require separate issue/pull request pairs.

For reference, I'm using NVDA alpha snapshots, Braille Extender dev build, and a BrailleNote Touch plus for braille work and to verify that changes do work.

Thanks.

josephsl commented 4 years ago

Hi,

At least for me, besides the ones posted above, I'm investigating about the following:

Thanks.

AAClause commented 4 years ago

Hi @josephsl, Regarding auto-scroll, I'm currently rewrite the feature. Please see #81. Your comments are welcome :) Thanks

dangero2000 commented 1 year ago

If merging Braille Extender features into the NVDA core is still ongoing, I'd like to suggest merging speech history. This makes programs previously incapable of outputting to braille displays accessible for braille users by sending speech output to the display. It's a feature I find myself using frequently, most notably in games. I feel this feature is important enough to be part of the core.