AAClause / BrailleExtender

NVDA add-on that improves braille support
https://andreabc.net/projects/NVDA_addons/BrailleExtender/
GNU General Public License v2.0
16 stars 17 forks source link

braille extender refuses to save settings when changing braille representation settings of unknown characters #49

Closed zstanecic closed 4 years ago

zstanecic commented 4 years ago

Try to change the braille representation settings and it will crach andrefuse to close the dialog,

Log complaints about the unregistered setting

AAClause commented 4 years ago

Hi, I can't reproduce this bug. Can you give more details and log please? Thanks

zstanecic commented 4 years ago
  1. Open settings, then braille tables
  2. In the undefined braille characters representation select use dots 25 questionmark,
  3. Press ok.

ERROR - globalPluginHandler.initialize (22:04:39.979) - MainThread (7664): Error initializing global plugin <class 'globalPlugins.brailleExtender.GlobalPlugin'> Traceback (most recent call last): File "globalPluginHandler.pyc", line 33, in initialize File "C:\Users\ninos\AppData\Roaming\nvda\addons\BrailleExtender\globalPlugins\brailleExtender__init.py", line 185, in init self.reloadBrailleTables() File "C:\Users\ninos\AppData\Roaming\nvda\addons\BrailleExtender\globalPlugins\brailleExtender\init__.py", line 306, in reloadBrailleTables patchs.setUndefinedChar() File "C:\Users\ninos\AppData\Roaming\nvda\addons\BrailleExtender\globalPlugins\brailleExtender\patchs.py", line 163, in setUndefinedChar v = huc.unicodeBrailleToDescription(getTextInBraille(s, getCurrentBrailleTables())) File "C:\Users\ninos\AppData\Roaming\nvda\addons\BrailleExtender\globalPlugins\brailleExtender\utils.py", line 255, in getTextInBraille else: table = [os.path.join(brailleTables.TABLES_DIR, table)] File "ntpath.pyc", line 115, in join File "genericpath.pyc", line 153, in _check_arg_types TypeError: join() argument must be str or bytes, not 'list' INFO - core.main (22:04:40.140) - MainThread (7664):

AAClause commented 4 years ago

Thanks a lot for these details. it should work now :)

zstanecic commented 4 years ago

This issue is successfully fixed in the latest dev version. It even broke the braille extender on start, respectively.