search

AAClause / BrailleExtender

NVDA add-on that improves braille support
https://andreabc.net/projects/NVDA_addons/BrailleExtender/
GNU General Public License v2.0
16 stars 17 forks source link

Improves document formatting & object presentation #64

Closed AAClause closed 7 months ago

AAClause commented 4 years ago

Remaining:

Fixes #17 Fixes #55 Fixes https://github.com/nvaccess/nvda/issues/7453 Fixes https://github.com/nvaccess/nvda/issues/7455 Fixes https://github.com/nvaccess/nvda/issues/6901 Fixes https://github.com/nvaccess/nvda/issues/11273

zstanecic commented 4 years ago

There is no difference between the justified and left alignment, respectively. Centered and right aligments are good! Really good job!

devinprater commented 4 years ago

Paragraphs used to be indented in Braille Extender, but are not anymore. This could be an option in the formatting settings. Also, I have tried to use the "hand over to Liblouis" option for some formatting styles, like bold, and get this error:

ERROR - unhandled exception (08:44:40.903) - MainThread (30732): Traceback (most recent call last): File "C:\Users\Devin\AppData\Roaming\nvda\addons\BrailleExtender\globalPlugins\brailleExtender\documentFormatting.py", line 436, in onOk )[self.bold.GetSelection()] File "config__init.pyc", line 1068, in setitem__ File "configobj\validate.pyc", line 615, in check File "configobj\validate.pyc", line 647, in _check_value File "configobj\validate.pyc", line 1332, in is_option configobj.validate.VdtValueError: the value "liblouis" is unacceptable. ERROR - unhandled exception (08:44:41.973) - MainThread (30732): Traceback (most recent call last): File "C:\Users\Devin\AppData\Roaming\nvda\addons\BrailleExtender\globalPlugins\brailleExtender\documentFormatting.py", line 436, in onOk )[self.bold.GetSelection()] File "config__init.pyc", line 1068, in setitem__ File "configobj\validate.pyc", line 615, in check File "configobj\validate.pyc", line 647, in _check_value File "configobj\validate.pyc", line 1332, in is_option configobj.validate.VdtValueError: the value "liblouis" is unacceptable.

Adriani90 commented 3 months ago

@aaclause I see you closed this PR, would you not be rather inclined to donate this valuable code to the NVDA repository via an upstream pull request to the NVDA core?

AAClause commented 3 months ago

@Adriani90 Great suggestion! However, I’m inclined to start anew as the current implementation relies heavily on hacks. I hope to dedicate some time to this soon. for this add-on has waned due to excessive improvisation, even though it was the catalyst for my interest in NVDA development eight years ago. Incorporating these features in NVDA Core might boost my motivation again. :)