search

AAClause / BrailleExtender

NVDA add-on that improves braille support
https://andreabc.net/projects/NVDA_addons/BrailleExtender/
GNU General Public License v2.0
16 stars 17 forks source link

Enable per region undefined chars processing mode change #65

Closed dawidpieper closed 4 years ago

dawidpieper commented 4 years ago

Adds flag parseUndefinedChars to braille.Region that is set to true by default. When it's set to true, Braille Extender works as before. When the flag is set to false for specific region, for example by other plugin, undefined chars in the region are ignored for this region.

AAClause commented 4 years ago

Thanks a lot @dawidpieper for your contribution! :-) I understand the purpose. Could you change the base branch? The best is create a specific branch from master with your changes.

zstanecic commented 4 years ago

Why to change the base branch,

As the master is considered stable?

Better merge this into dev, where we accumulate fixes and new features, and merge this with all new fixes.

From: André-Abush Clause notifications@github.com Sent: Friday, June 12, 2020 12:27 PM To: Andre9642/BrailleExtender BrailleExtender@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [Andre9642/BrailleExtender] Enable per region undefined chars processing mode change (#65)

Thanks a lot @dawidpieper https://github.com/dawidpieper for your contribution! :-) I understand the purpose. Could you change the base branch? The best is create a specific branch from master with your changes.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Andre9642/BrailleExtender/pull/65#issuecomment-643198834 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVCDE3723NFD2HPTUIHUCTRWH7GXANCNFSM4N4FBDBA . https://github.com/notifications/beacon/ACVCDE6P2WXME2TMRYSIJQTRWH7GXA5CNFSM4N4FBDBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEZLG64Q.gif

AAClause commented 4 years ago

Why to change the base branch, As the master is considered stable?

Because master branch is considered stable ;) Adding a feature is better on stable base.

Better merge this into dev, where we accumulate fixes and new features, and merge this with all new fixes.

Don't worry, I'll merge the PR in dev branch first. It's the same for other pull requests.

dawidpieper commented 4 years ago

Thanks, I'm creating new pull request and closing this