AAClause / BrailleExtender

NVDA add-on that improves braille support
https://andreabc.net/projects/NVDA_addons/BrailleExtender/
GNU General Public License v2.0
16 stars 17 forks source link

Code restructuring: properly port Braille Extender to Python 3, remove Python 2 idioms and facilities #69

Closed josephsl closed 3 years ago

josephsl commented 4 years ago

Hi,

A high priority blocker for #68

Before linting can proceed, it is important to port Braille Extender to Python 3. This is because add-on manifest says NVDA 2019.3 is the minimum supported version, and NVDA Core expects Python 3.7 or later.

The following will be done:

Thanks.

AAClause commented 3 years ago

Hi @josephsl,

  • Remove Python 2 checks
  • Remove unicode literals import directive

I think all these are done.

  • Many more

Could you elaborate on this? Perhaps it's better to close this issue and open others.

Thanks

josephsl commented 3 years ago

Hi, pretty much most of these are done. Let’s open new issues for others.

From: André-Abush Clause notifications@github.com Sent: Thursday, November 19, 2020 2:38 AM To: Andre9642/BrailleExtender BrailleExtender@noreply.github.com Cc: Joseph Lee joseph.lee22590@gmail.com; Mention mention@noreply.github.com Subject: Re: [Andre9642/BrailleExtender] Code restructuring: properly port Braille Extender to Python 3, remove Python 2 idioms and facilities (#69)

Hi @josephsl https://github.com/josephsl ,

I think all these are done.

Could you elaborate on this? Perhaps it's better to close this issue and open others.

Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Andre9642/BrailleExtender/issues/69#issuecomment-730283936 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4AXEHZA6QHUFGORFXDUBLSQTYQBANCNFSM4O3P245A .