search

AAClause / BrailleExtender

NVDA add-on that improves braille support
https://andreabc.net/projects/NVDA_addons/BrailleExtender/
GNU General Public License v2.0
16 stars 17 forks source link

Add-on gestures: convert gestures map into script decorator functions #73

Open josephsl opened 4 years ago

josephsl commented 4 years ago

Hi,

Continuing code refactoring, this time code modernization:

In 2018, scriptHandler.script decorator was introduced, allowing add-on developers to specify gestures, input help messages, and categories for a script in one place. In case of Braille Extender add-on, using script decorator modernizes the add-on. It also has another benefit: it removes use of OrderedDict when defining gestures, as Python 3.7 guarantees insertion order for dictionaries (this may involve either removing gestures map or rearranging methods in the global plugin class to preserve original gestures map order).

Thanks.

josephsl commented 4 years ago

Hi,

Optionally, I may need to fix grammar issues found in input help messages for some scripts, but I won't do it as it will cause problems for translators in the short term.

Thanks.

zstanecic commented 4 years ago

Hi Joseph,

Go with the grammar fixing, as translators will benefit from this.

It’s time to fix French grammar in English, as some users told me that there were a lot of errors in the languages I maintain.

From: Joseph Lee notifications@github.com Sent: Thursday, July 16, 2020 7:24 PM To: Andre9642/BrailleExtender BrailleExtender@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [Andre9642/BrailleExtender] Add-on gestures: convert gestures map into script decorator functions (#73)

Hi,

Optionally, I may need to fix grammar issues found in input help messages for some scripts, but I won't do it as it will cause problems for translators in the short term.

Thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Andre9642/BrailleExtender/issues/73#issuecomment-659556002 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVCDE7ORE3SHLVVHH5H6HTR34ZSFANCNFSM4O4TYZNQ . https://github.com/notifications/beacon/ACVCDE65NAIZS3GAOPT6F6TR34ZSFA5CNFSM4O4TYZN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOE5IANIQ.gif

josephsl commented 4 years ago

Hi, I’ll do that as part of a separate pull request (not this one yet). Thanks.

From: zstanecic notifications@github.com Sent: Thursday, July 16, 2020 10:36 AM To: Andre9642/BrailleExtender BrailleExtender@noreply.github.com Cc: Joseph Lee joseph.lee22590@gmail.com; Author author@noreply.github.com Subject: Re: [Andre9642/BrailleExtender] Add-on gestures: convert gestures map into script decorator functions (#73)

Hi Joseph,

Go with the grammar fixing, as translators will benefit from this.

It’s time to fix French grammar in English, as some users told me that there were a lot of errors in the languages I maintain.

From: Joseph Lee notifications@github.com Sent: Thursday, July 16, 2020 7:24 PM To: Andre9642/BrailleExtender BrailleExtender@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [Andre9642/BrailleExtender] Add-on gestures: convert gestures map into script decorator functions (#73)

Hi,

Optionally, I may need to fix grammar issues found in input help messages for some scripts, but I won't do it as it will cause problems for translators in the short term.

Thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Andre9642/BrailleExtender/issues/73#issuecomment-659556002 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVCDE7ORE3SHLVVHH5H6HTR34ZSFANCNFSM4O4TYZNQ . https://github.com/notifications/beacon/ACVCDE65NAIZS3GAOPT6F6TR34ZSFA5CNFSM4O4TYZN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOE5IANIQ.gif

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Andre9642/BrailleExtender/issues/73#issuecomment-659562470 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4AXEBVLLAMEJE3663KWRTR3426NANCNFSM4O4TYZNQ .