search

AAClause / BrailleExtender

NVDA add-on that improves braille support
https://andreabc.net/projects/NVDA_addons/BrailleExtender/
GNU General Public License v2.0
16 stars 17 forks source link

Freedomscientific: Focus navigation "wizwheel" keys, right and left, should be switched #88

Closed devinprater closed 4 years ago

devinprater commented 4 years ago

Hello,

I've been using Braille Extender seriously for a week or so now, and love it! The many keyboard commands, the work on formatting, and many more settings that I suspect even JAWS will ever have, really sets Braille Extender as a leader in use of braille displays. There are just a few issues that I've found, and one, not showing the paragraph indentation, that I'm not sure is an issue, so just tell me and I'll make an issue about that or not.

This issue is about the key map configuration. I use a Focus 14, fifth generation, braille display. On it, there are many buttons, a pair of two of these handling navigation. The one on the left, in JAWS, handles lines, and on the right handles scrolling. You can change this by a button above the scroll buttons. In NVDA, without Braille Extender, the right scroll buttons pan the display, scrolling one display length at a time. In Braille Extender, though, they move by lines.

This is important because there are times where the panning buttons themselves, on the front side of the display, are uncomfortable to press. I can use the left navigation scroll buttons,, called LeftWizWheel, but that's awkward to press when my fingers are at the right end of the display. So, I'd like the function of these two to be switched, so that the RightWizWheel buttons, up and down, pan the display, while the LeftWizWheel buttons move by line.

AAClause commented 4 years ago

Hi @devinprater ! Thanks for this report.

I've been using Braille Extender seriously for a week or so now, and love it!

Happy to hear that :)

There are just a few issues that I've found, and one, not showing the paragraph indentation, that I'm not sure is an issue, so just tell me and I'll make an issue about that or not.

Formatting report is still under development. Don't hesitate to comment on the appropriate pull request (#64)!

Regarding the main issue: maybe remove rightwizwheelup and rightwizwheeldown mappings from the add-on is the best. I've just noticed that leftWizWheelPress and rightWizWheelPress are mapped to toggleLeftWizWheelAction and toggleRightWizWheelAction scripts. See the following link (especially lines 489 to 504):

https://github.com/nvaccess/nvda/blob/327b2dde292a71d8123650a2515adeaa8aac5fb7/source/brailleDisplayDrivers/freedomScientific.py#L489

I suppose that these scripts reproduce the JAWS behavior. Can you confirm it to me? Thanks.

devinprater commented 4 years ago

Yes, the way NVDA does it naturally is perfect, and it does what JAWS does.

AAClause commented 4 years ago

Thanks for clarifying. So I've just removed these mappings. Can you test with the new dev version?

devinprater commented 4 years ago

Yes, this works, thanks so much.

zstanecic commented 4 years ago

Hi Devin,

I fit works,

I will close this.

AAClause commented 4 years ago

@zstanecic I already merged the fix into the default branch (master), so the issue was automatically closed :) More details here.