search

AAGAN / WilliamsonMethod

c++ implementation of Williamson's method
0 stars 0 forks source link

Optimizing your code #10

Closed AAGAN closed 7 years ago

AAGAN commented 7 years ago

I really like the code you have created. It would be good if you run a [static code analysis tool] (https://github.com/danmar/cppcheck) to fix non-standard code. Also, please run the doxygen on your code and see if your comments are compiling properly. Thanks for your help on this project.

llddrr92 commented 7 years ago

Done. Static code analysis had only a few style warnings, and the html generated by doxygen is under the document folder. I'll send a pull request when I have more things to commit.

AAGAN commented 7 years ago

I couldn't find the doxygen documentation under the documents folder of your repository.

On Jul 10, 2017, at 4:46 PM, Daren Liu notifications@github.com wrote:

Done. Static code analysis had only a few style warnings, and the html generated by doxygen is under the document folder. I'll send a pull request when I have more things to commit.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

llddrr92 commented 7 years ago

I did doxygen locally on the work laptop and thought I committed it to my repository, but apparently not. I'll do that tomorrow. Sorry!

Also I just started thinking about comparing Novec prediction with the experimental data you gave me and realized there is no starting storage temperature recorded in those data. How do you suggest I go about that?

AAGAN commented 7 years ago

Please use 20 degrees Celsius as the starting temperature. (I asked the people who did the experiments and they made sure they start the tests at 20 degrees Celsius.)

llddrr92 commented 7 years ago

Awesome thanks! The corresponding doxygen document is committed to my repo now if you want to check it out. (There's not much to see though due to the simple structure)

AAGAN commented 7 years ago

Also, Please add the properties of the agent that caused Tom's software to break down in the API of your williamson function so that this error won't happen if we go to a different agent.