search

AAGAN / WilliamsonMethod

c++ implementation of Williamson's method
0 stars 0 forks source link

First edition of Williamson code #8

Closed llddrr92 closed 7 years ago

llddrr92 commented 7 years ago

Several updates in this pull request:

  1. I have transferred the Halon property data from Williamson paper into a CSV data file. For Novec I'm using the data from VB code. Note Halon has Henry's constants data, while Novec assumes a linear relation with temperature.

  2. I have inputted the equations just like the code in paper for the container state during discharge. It works but is not very robust, and the current result is not correct in that liquid weight drops to negative as temperature drops. I don't know whether that's due to some unit conversion issue or initial condition choice, or maybe it's correct and only needs to be stopped when all liquid drains, or anything else. It also won't converge for certain pressure difference threshold. I'm going into more details at this.

  3. Under the documents directory I have added the code flow chart and a summary of all email responses in terms of software inquires.

I don't know why it can't automatically merge again this time. (Well it seems conflict is only for the readme file so that's good.) Let me know if you want me to stop by and work on it together. Thanks!

AAGAN commented 7 years ago

please fetch the changes from my master branch so that there are no conflict when you send me pull requests.